linux-kernel - Re: [PATCH v8 1/5] rust: devres: style for imports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260115100625.432482dc.zhiw@nvidia.com>
Date: Thu, 15 Jan 2026 10:07:02 +0200
From: Zhi Wang <zhiw@...dia.com>
To: Gary Guo <gary@...yguo.net>
CC: <rust-for-linux@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dakr@...nel.org>, <aliceryhl@...gle.com>,
	<bhelgaas@...gle.com>, <kwilczynski@...nel.org>, <ojeda@...nel.org>,
	<alex.gaynor@...il.com>, <boqun.feng@...il.com>, <bjorn3_gh@...tonmail.com>,
	<lossin@...nel.org>, <a.hindborg@...nel.org>, <tmgross@...ch.edu>,
	<markus.probst@...teo.de>, <helgaas@...nel.org>, <cjia@...dia.com>,
	<smitra@...dia.com>, <ankita@...dia.com>, <aniketa@...dia.com>,
	<kwankhede@...dia.com>, <targupta@...dia.com>, <acourbot@...dia.com>,
	<joelagnelf@...dia.com>, <jhubbard@...dia.com>, <zhiwang@...nel.org>, "Miguel
 Ojeda" <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH v8 1/5] rust: devres: style for imports

On Tue, 13 Jan 2026 14:25:14 +0000
"Gary Guo" <gary@...yguo.net> wrote:

> On Tue Jan 13, 2026 at 9:22 AM GMT, Zhi Wang wrote:
> > Convert all imports in the devres to use "kernel vertical" style. Drop
> > unnecessary imports covered by prelude::*.
> 
> There doesn't appear to be any dropped import?

Yes. It has been done by someone already during the rebase. I will update
this.

> 
> Best,
> Gary
> 
> >
> > Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
> > Signed-off-by: Zhi Wang <zhiw@...dia.com>
> > ---
> >  rust/kernel/devres.rs | 16 +++++++++++++---
> >  1 file changed, 13 insertions(+), 3 deletions(-)
> >
> > diff --git a/rust/kernel/devres.rs b/rust/kernel/devres.rs
> > index db02f8b1788d..43089511bf76 100644
> > --- a/rust/kernel/devres.rs
> > +++ b/rust/kernel/devres.rs
> > @@ -254,8 +254,12 @@ pub fn device(&self) -> &Device {
> >      /// # Examples
> >      ///
> >      /// ```no_run
> > -    /// # #![cfg(CONFIG_PCI)]
> > -    /// # use kernel::{device::Core, devres::Devres, pci};
> > +    /// #![cfg(CONFIG_PCI)]
> > +    /// use kernel::{
> > +    ///     device::Core,
> > +    ///     devres::Devres,
> > +    ///     pci, //
> > +    /// };
> >      ///
> >      /// fn from_core(dev: &pci::Device<Core>, devres:
> > Devres<pci::Bar<0x4>>) -> Result { ///     let bar =
> > devres.access(dev.as_ref())?; @@ -358,7 +362,13 @@ fn
> > register_foreign<P>(dev: &Device<Bound>, data: P) -> Result /// #
> > Examples ///
> >  /// ```no_run
> > -/// use kernel::{device::{Bound, Device}, devres};
> > +/// use kernel::{
> > +///     device::{
> > +///         Bound,
> > +///         Device, //
> > +///     },
> > +///     devres, //
> > +/// };
> >  ///
> >  /// /// Registration of e.g. a class device, IRQ, etc.
> >  /// struct Registration;
>