linux-kernel - Re: [PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cdf03250dd923859638de4850ce4b4e4279bf8a.camel@codeconstruct.com.au>
Date: Thu, 15 Jan 2026 11:42:45 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Kyle Hsieh <kylehsieh1995@...il.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, Krzysztof
 Kozlowski	 <krzysztof.kozlowski@....qualcomm.com>, Rob Herring
 <robh@...nel.org>,  Krzysztof Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Joel Stanley	 <joel@....id.au>
Subject: Re: [PATCH v3 0/2] Add Meta(Facebook) ventura2 BMC(AST2600)

On Tue, 2026-01-13 at 08:17 +0100, Krzysztof Kozlowski wrote:
> On 13/01/2026 03:57, Kyle Hsieh wrote:
> > Summary:
> > Add linux device tree entry related to Meta(Facebook) ventura2.
> > specific devices connected to BMC(AST2600) SoC.
> > 
> > Signed-off-by: Kyle Hsieh <kylehsieh1995@...il.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
> 
> Where? How is this possible?

Kyle: Tags only apply to the patches they were provided for. Tacking
this one on the cover letter implies Krzysztof has acked the devicetree
as well, which is not the case with respect to [1].

[1]: https://lore.kernel.org/all/20251223-ginger-worm-of-swiftness-a8fa05@quoll/

It appears you're already using b4. b4 also handles tags for you:

https://b4.docs.kernel.org/en/latest/contributor/trailers.html

As it suggests, run `b4 trailers -u` to automatically and correctly
apply tags you have received for your changes.

Please fix the issue here (remove the tag from the cover-letter, apply
tags to the correct patches) and send again, _after_ you've addressed
all further feedback on v3.

Andrew