linux-kernel - RE: [PATCH 3/3] dt-bindings: PCI: fsl,imx6q-pcie: Remove the deprecated "reset-gpio-active-high" property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <VI0PR04MB1211405BEFB0BE5A24F75BB1E928CA@VI0PR04MB12114.eurprd04.prod.outlook.com>
Date: Thu, 15 Jan 2026 09:23:59 +0000
From: Sherry Sun <sherry.sun@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"festevam@...il.com" <festevam@...il.com>, "kwilczynski@...nel.org"
	<kwilczynski@...nel.org>, "mani@...nel.org" <mani@...nel.org>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, Hongxing Zhu
	<hongxing.zhu@....com>, Frank Li <frank.li@....com>, "l.stach@...gutronix.de"
	<l.stach@...gutronix.de>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>
CC: "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] dt-bindings: PCI: fsl,imx6q-pcie: Remove the
 deprecated "reset-gpio-active-high" property



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, January 15, 2026 5:08 PM
> To: Sherry Sun <sherry.sun@....com>; robh@...nel.org;
> krzk+dt@...nel.org; conor+dt@...nel.org; shawnguo@...nel.org;
> s.hauer@...gutronix.de; festevam@...il.com; kwilczynski@...nel.org;
> mani@...nel.org; andriy.shevchenko@...ux.intel.com;
> bhelgaas@...gle.com; Hongxing Zhu <hongxing.zhu@....com>; Frank Li
> <frank.li@....com>; l.stach@...gutronix.de; lpieralisi@...nel.org
> Cc: kernel@...gutronix.de; devicetree@...r.kernel.org; imx@...ts.linux.dev;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 3/3] dt-bindings: PCI: fsl,imx6q-pcie: Remove the
> deprecated "reset-gpio-active-high" property
> 
> On 15/01/2026 08:18, Sherry Sun wrote:
> > Commit 2e81122d681c ("PCI: imx6: Convert to use agnostic GPIO API")
> > deleted the support of "reset-gpio-active-high" property in imx6 PCIe
> > driver. This deprecated preoperty is no longer used in any DTS file,
> > let's also remove this in dt-binding.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > ---
> >  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > index 12a01f7a5744..6b18264afecf 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> > @@ -63,12 +63,6 @@ properties:
> >        reset signal. It's not polarity aware and defaults to active-low reset
> >        sequence (L=reset state, H=operation state) (optional required).
> >
> > -  reset-gpio-active-high:
> > -    description: If present then the reset sequence using the GPIO
> > -      specified in the "reset-gpio" property is reversed (H=reset state,
> > -      L=operation state) (optional required).
> 
> You had one command to run before preparing such patch:
> 
> git grep reset-gpio-active-high
> 
> so now you made this ABI undocumented.
> 
Hi Krzysztof,
Yes, Francesco also reminded me for this, thanks for the catch, will be more careful next time.

Best Regards
Sherry