linux-kernel - Re: [PATCH] riscv: defconfig: enable NLS_ISO8859

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <345da49c-b8b5-8538-6231-c614792c9092@kernel.org>
Date: Wed, 14 Jan 2026 17:19:57 -0700 (MST)
From: Paul Walmsley <pjw@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
cc: Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, 
    Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, 
    Heinrich Schuchardt <heinrich.schuchardt@...onical.com>, 
    linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: defconfig: enable NLS_ISO8859_1

On Sun, 11 Jan 2026, Javier Carrasco wrote:

> NLS_ISO8859_1 was enabled as a module with commit efe1e08bca9a ("riscv:
> defconfig: enable NLS_CODEPAGE_437, NLS_ISO8859_1"), but the
> NLS_CODEPAGE_437 counterpart is selected as built-in. The commit does
> not explain the reason behind, and it is not consistent with the
> defconfig for ARM64 that also enables these modules to mount EFI system
> partitions.
> 
> Select NLS_ISO8859_1 as built-in to provide both requirements within the
> kernel image.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
> I stumbled upon this while scripting commands to launch
> qemu-system-aarch64 and qemu-system-riscv64 with debian no-cloud images
> and -kernel to provide a defconfig kernel in both cases. I expected the
> same behavior to mount the EFI partition, but it failed for riscv unless
> the modules were installed/provided. That didn't happen for arm64 as
> NLS_ISO8859_1 is built-in.
> 
> If there are no good reasons to keep these configurations differently
> for these architectures and only have NLS_CODEPAGE_437 bult-in, having
> NLS_ISO8859_1 built-in is more consistent and the EFI partitions are
> mounted more easily. This is the only configuration that had to be
> modified to boot Debian 12 and 13.

Thanks, queued for v6.20.


- Paul