linux-kernel - Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add max22007

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260115-elegant-hopping-kangaroo-6cd32b@quoll>
Date: Thu, 15 Jan 2026 10:24:19 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Janani Sunil <janani.sunil@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	jan.sun97@...il.com, gastmaier@...il.com
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add max22007

On Wed, Jan 14, 2026 at 05:17:01PM +0100, Janani Sunil wrote:
> Devicetree bindings for MAX22007 4-channel
> 12-bit DAC that drives a voltage or current
> output on each channel

What is happening with this patchset - why are you making somehow
unrelated, different, unexpected and incorrect changes like ones above?

You are supposed to work with Git e.g. on dedicated branch, so you
clearly see what you did. Why doing such changes?


> 
> Signed-off-by: Janani Sunil <janani.sunil@...log.com>
> ---
>  .../devicetree/bindings/iio/dac/adi,max22007.yaml  | 116 +++++++++++++++++++++
>  MAINTAINERS                                        |  15 +++
>  2 files changed, 131 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml
> new file mode 100644
> index 000000000000..c2f65d9e42d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,max22007.yaml
> @@ -0,0 +1,116 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/adi,max22007.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices MAX22007 DAC device driver

Why did you changed this? What else changed?

Nothing about this was mentioned in the changelog.

I finished the review here. Please be concious what you are
changing, do not introduce random changes and then write correct
changelogs describing what you did.

You already received review which you SILENTLY ignored. That is not
acceptable, either. You MUST provide reasons!

Now, that review is invalidated anyway.


> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5b11839cba9d..c378d4b8f5ae 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1594,6 +1594,21 @@ W:	https://ez.analog.com/linux-software-drivers
>  F:	Documentation/devicetree/bindings/iio/dac/adi,ad9739a.yaml
>  F:	drivers/iio/dac/ad9739a.c
>  
> +ANALOG DEVICES INC AD8460 DRIVER
> +M:	Mariel Tinaco <Mariel.Tinaco@...log.com>
> +L:	linux-iio@...r.kernel.org
> +S:	Supported
> +W:	https://ez.analog.com/linux-software-drivers
> +F:	Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml
> +F:	drivers/iio/dac/ad8460.c


What?

NAK