linux-kernel - Re: [PATCH v3] staging: octeon: Remove port status typedefs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026011503-cardinal-wildcat-64b1@gregkh>
Date: Thu, 15 Jan 2026 12:31:56 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Karthikey Kadati <karthikey3608@...il.com>
Cc: tsbogend@...ha.franken.de, linux-staging@...ts.linux.dev,
	linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3] staging: octeon: Remove port status typedefs

On Wed, Jan 14, 2026 at 10:28:34PM +0530, Karthikey Kadati wrote:
> Remove cvmx_pip_port_status_t and cvmx_pko_port_status_t typedefs and
> replace them with struct cvmx_pip_port_status and struct cvmx_pko_port_status
> to match Linux kernel coding style.
> 
> This also updates the MIPS architecture headers to name the anonymous
> structs so they can be referenced by the staging driver.
> 
> Reported-by: kernel test robot <lkp@...el.com>

The test robot reported that typedefs need to be removed?  Or did it
just find a failure in your previous change?

> Closes: https://lore.kernel.org/oe-kbuild-all/202601131108.A90iCRFi-lkp@intel.com/
> Signed-off-by: Karthikey Kadati <karthikey3608@...il.com>
> ---
> v3:
>   - Fix build failure by naming anonymous structs in MIPS headers
>     (Reported by kernel test robot).
>   - Add Reported-by and Closes tags.
> v2:
>   - Remove invalid "Unix Antigravity" Signed-off-by.
>   - Submit as standalone patch (detached from unrelated series).
> 
>  arch/mips/include/asm/octeon/cvmx-pip.h |  2 +-
>  arch/mips/include/asm/octeon/cvmx-pko.h |  2 +-
>  drivers/staging/octeon/ethernet.c       |  4 ++--
>  drivers/staging/octeon/octeon-stubs.h   | 12 ++++++------
>  4 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/mips/include/asm/octeon/cvmx-pip.h b/arch/mips/include/asm/octeon/cvmx-pip.h
> index 01ca7267a..cb3342313 100644
> --- a/arch/mips/include/asm/octeon/cvmx-pip.h
> +++ b/arch/mips/include/asm/octeon/cvmx-pip.h
> @@ -180,7 +180,7 @@ typedef union {
>  /**
>   * Status statistics for a port
>   */
> -typedef struct {
> +typedef struct cvmx_pip_port_status {

Why is this typedef left here?


>  	/* Inbound octets marked to be dropped by the IPD */
>  	uint32_t dropped_octets;
>  	/* Inbound packets marked to be dropped by the IPD */
> diff --git a/arch/mips/include/asm/octeon/cvmx-pko.h b/arch/mips/include/asm/octeon/cvmx-pko.h
> index f18a7f24d..46bb5ddcb 100644
> --- a/arch/mips/include/asm/octeon/cvmx-pko.h
> +++ b/arch/mips/include/asm/octeon/cvmx-pko.h
> @@ -114,7 +114,7 @@ typedef enum {
>  	CVMX_PKO_LOCK_CMD_QUEUE = 2,
>  } cvmx_pko_lock_t;
>  
> -typedef struct {
> +typedef struct cvmx_pko_port_status {

Same here, I thought you were removing typedefs?

thanks,

greg k-h