linux-kernel - Re: [PATCH v8 03/10] spmi: Remove unneeded goto in spmi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176852901295.16445.358528724346630388@lazor>
Date: Thu, 15 Jan 2026 20:03:32 -0600
From: Stephen Boyd <sboyd@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, jic23@...nel.org
Cc: dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org, arnd@...db.de, gregkh@...uxfoundation.org, srini@...nel.org, vkoul@...nel.org, neil.armstrong@...aro.org, sre@...nel.org, angelogioacchino.delregno@...labora.com, krzk@...nel.org, dmitry.baryshkov@....qualcomm.com, quic_wcheng@...cinc.com, melody.olvera@....qualcomm.com, quic_nsekar@...cinc.com, ivo.ivanov.ivanov1@...il.com, abelvesa@...nel.org, luca.weiss@...rphone.com, konrad.dybcio@....qualcomm.com, mitltlatltl@...il.com, krishna.kurapati@....qualcomm.com, linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org, linux-pm@...r.kernel.org, kernel@...labora.com
Subject: Re: [PATCH v8 03/10] spmi: Remove unneeded goto in spmi_device_add() error path

Quoting AngeloGioacchino Del Regno (2026-01-14 03:27:35)
> If any error happens during device_add() just return inside of the
> conditional, as the goto path doesn't do anything else if not just
> returning.
> 
> While at it, to improve readability, also change this function to
> explicitly return 0 (for success) at the end.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---

Acked-by: Stephen Boyd <sboyd@...nel.org>