linux-kernel - Re: [PATCH net-next v4] net: sfp: add SMBus I2C block support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jyxhwzak.fsf@miraculix.mork.no>
Date: Fri, 16 Jan 2026 12:51:47 +0100
From: Bjørn Mork <bjorn@...k.no>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jonas Jelonek <jelonek.jonas@...il.com>,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S
 . Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net-next v4] net: sfp: add SMBus I2C block support

"Russell King (Oracle)" <linux@...linux.org.uk> writes:
> On Fri, Jan 16, 2026 at 12:16:11PM +0100, Jonas Jelonek wrote:
>
>> When I come to trying to work on that, should that all be kept in
>> mdio-i2c.c? I'm asking because we have a downstream implementation
>> moving that SMbus stuff to mdio-smbus.c. This covers quite a lot right
>> now, C22/C45 and Rollball, but just with byte access [1]. Because that
>> isn't my work, I'll need to check with the original authors and adapt this
>> for an upstream patch, trying to add word + block access.
>> 
>> Kind regards,
>> Jonas
>> 
>> [1] https://github.com/openwrt/openwrt/blob/66b6791abe6f08dec2924b5d9e9e7dac93f37bc4/target/linux/realtek/patches-6.12/712-net-phy-add-an-MDIO-SMBus-library.patch
>
> My personal view on this is not suitable for sharing publicly. I'm sure
> people can guess what my view is and why. (Look at the age of the
> patch, and it's clearly "lets re-implement mdio-i2c" rather than "let's
> adapt it".

FWIW, I agree if my guess is correct :-)

I see that my name is on that downstream patch, due to the RollBall
additions there. It was never intended for mainline in that form.  I
originally implemented the SMBus RollBall access methods as part of
mdio-i2c.c and that's where they belong IMHO.

It was briefly discussed here.  But I never had enough time and
motivation to finish this properly. So it ended up as an OpenWrt
specific hack for now.  I certainly won't object to anyone else reusing
any of the code I wrote, if it is any help at all.

Not sure the c45 SMBus stuff in openwrt ever worked BTW. I have only
tested c22 and RollBall over SMBus.


Bjørn