lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2026011631-hungry-uncouth-0d0b@gregkh>
Date: Fri, 16 Jan 2026 14:07:58 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Archit Anant <architanant5@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8723bs: fix spacing around operators

On Wed, Jan 14, 2026 at 03:19:47PM +0530, Archit Anant wrote:
> From: ArchitAnant <architanant5@...il.com>
> 
> Add missing spaces around mathematical and logical operators
> (+, -, /, |, ?, :) to comply with the Linux kernel coding style.
> 
> Issue identified by checkpatch.pl.
> 
> Signed-off-by: ArchitAnant <architanant5@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 28 ++++++++++++------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index ef2d92b5588a..03274738c94e 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -175,7 +175,7 @@ int rtw_init_cmd_priv(struct	cmd_priv *pcmdpriv)
>  	if (!pcmdpriv->cmd_allocated_buf)
>  		return -ENOMEM;
>  
> -	pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf  +  CMDBUFF_ALIGN_SZ - ((SIZE_PTR)(pcmdpriv->cmd_allocated_buf) & (CMDBUFF_ALIGN_SZ-1));
> +	pcmdpriv->cmd_buf = pcmdpriv->cmd_allocated_buf  +  CMDBUFF_ALIGN_SZ - ((SIZE_PTR)(pcmdpriv->cmd_allocated_buf) & (CMDBUFF_ALIGN_SZ - 1));

Why are there additional ' ' around the first '+' character?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ