linux-kernel - Re: [PATCH v3 4/4] staging: rtl8723bs: fix line length and alignment issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026011640-smudgy-kleenex-afb1@gregkh>
Date: Fri, 16 Jan 2026 14:14:20 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Khushal Chitturi <khushalchitturi@...il.com>
Cc: dan.carpenter@...aro.org, straube.linux@...il.com, hansg@...nel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/4] staging: rtl8723bs: fix line length and alignment
 issues

On Fri, Jan 16, 2026 at 11:00:52AM +0530, Khushal Chitturi wrote:
>  	/*  (1) RTS_Threshold is compared to the MPDU, not MSDU. */
> -	/*  (2) If there are more than one frag in  this MSDU, only the first frag uses protection frame. */
> +	/*  (2) If there are more than one frag in this MSDU,
> +	 *  only the first frag uses protection frame.
> +	 */

Break a sentance on the line length, not the ',' character.

Otherwise, you get odd looking lines like this one:

> @@ -656,7 +672,9 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p
>  	pattrib->pktlen = pktfile.pkt_len;
>  
>  	if (pattrib->ether_type == ETH_P_IP) {
> -		/*  The following is for DHCP and ARP packet, we use cck1M to tx these packets and let LPS awake some time */
> +		/*  The following is for DHCP and ARP packet,
> +		 *  we use cck1M to tx these packets and let LPS awake some time
> +		 */

Thanks,

greg k-h