linux-kernel - Re: [PATCH] rust/drm: tyr: Convert to the register!() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <25EE982E-B03D-4C50-B973-34AC4FFA96B6@collabora.com>
Date: Fri, 16 Jan 2026 10:38:28 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Gary Guo <gary@...yguo.net>
Cc: Dirk Behme <dirk.behme@...il.com>,
 Danilo Krummrich <dakr@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>,
 Steven Price <steven.price@....com>,
 dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust/drm: tyr: Convert to the register!() macro


>>> 
>>> Is there any reason why you replace the UPPERCASE register names with
>>> CamelCase ones?
>>> 
>>> I was under the impression that we want to use UPPERCASE for register
>>> names. Like in nova
>>> 
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/nova-core/regs.rs
>> 
>> Not really. UPPERCASE for non-const items will trigger the linter. The Nova
>> people chose to #[allow] this to align with OpenRM and, IIRC from the LPC
>> discussions, their registers are automatically generated from some internal
>> docs.
>> 
>> We have only a few, we can simply convert them to CamelCase.
> 
> Frankly, register names do look nicer in UPPER_CASE, especially that they're in
> many cases, packed with acronyms.
> 
> Best,
> Gary
> 

I don’t have an opinion here, to be honest. I think CamelCase does make it
easier on the eyes since our register names look quite simple, specially when
compared to Nova. However, I can switch to UPPER_CASE and add an
#![allow(non_camel_case_types)] if more people chime in.