linux-kernel - Re: [PATCH v1 2/2] dt-bindings: i2c: add force-set-sda property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06b1a681-4190-4552-a092-22dbdecf561c@kernel.org>
Date: Fri, 16 Jan 2026 15:14:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jie Li <lj29312931@...il.com>, wsa@...nel.org
Cc: linux-i2c@...r.kernel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, devicetree@...r.kernel.org, linus.walleij@...aro.org,
 linux-kernel@...r.kernel.org, Jie Li <jie.i.li@...ia.com>
Subject: Re: [PATCH v1 2/2] dt-bindings: i2c: add force-set-sda property

On 14/01/2026 15:13, Jie Li wrote:
> Document the new "force-set-sda" optional property.
> This property is used for hardware where the SDA line is open-drain
> but the standard driver-level check (like gpiod_get_direction) might
> not correctly reflect the ability to drive the line for bus recovery.

I think Linus explained well why this does not fit DT, so also formally
responding here - use proper GPIO flags, when SDA is open-drain.

> 
> Signed-off-by: Jie Li <jie.i.li@...ia.com>

This does not match From address. You need to always check your patches
with checkpatch.


Best regards,
Krzysztof