linux-kernel - Re: [PATCH] mailbox: pcc: Remove spurious IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWpK-dMK3t0VVqFY@bogus>
Date: Fri, 16 Jan 2026 14:28:09 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Mark Brown <broonie@...nel.org>
Cc: Jassi Brar <jassisinghbrar@...il.com>,
	Sudeep Holla <sudeep.holla@....com>,
	Aishwarya TCV <Aishwarya.TCV@....com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mailbox: pcc: Remove spurious IRQF_ONESHOT usage

On Fri, Jan 16, 2026 at 02:07:40PM +0000, Mark Brown wrote:
> The PCC code currently specifies IRQF_ONESHOT if the interrupt could
> potentially be shared but doesn't actually use request_threaded_irq() and
> the interrupt handler does not use IRQ_WAKE_THREAD so IRQF_ONESHOT is
> never relevant. Since commit aef30c8d569c ("genirq: Warn about using
> IRQF_ONESHOT without a threaded handler") specifying it has resulted in a
> WARN_ON(), fix this by removing IRQF_ONESHOT.
>

Looking back, can't think of any reason why we retained IRQF_ONESHOT
when we added IRQF_SHARED. Thanks for spotting and fixing it.

Reviewed-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep