linux-kernel - Re: [PATCH 0/6] drm/imagination: Introduce hardware support check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c26d3ca38e46e76e1b2fa1b5eaa378b5b436fc3.camel@imgtec.com>
Date: Fri, 16 Jan 2026 15:08:42 +0000
From: Alessio Belle <Alessio.Belle@...tec.com>
To: Matt Coster <Matt.Coster@...tec.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "simona@...ll.ch"
	<simona@...ll.ch>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        "airlied@...il.com" <airlied@...il.com>,
        Frank Binns <Frank.Binns@...tec.com>,
        Brajesh Gupta
	<Brajesh.Gupta@...tec.com>,
        "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>,
        Alexandru Dadu
	<Alexandru.Dadu@...tec.com>,
        "mripard@...nel.org" <mripard@...nel.org>
Subject: Re: [PATCH 0/6] drm/imagination: Introduce hardware support check

On Tue, 2026-01-13 at 10:16 +0000, Matt Coster wrote:
> We're seeing an influx of contributions to add support for lots of
> different hardware containing Imagination GPUs, and for that we're
> incredibly grateful.
> 
> Out of an abundance of caution, let's mark anything with intial support
> that isn't yet reasonably widely tested as "experimental".
> 
> This serves two goals:
>  - Don't accidentally declare that hardware with early support is usable
>    without sufficient testing.
>  - Allow for future breaking changes that would normally not be allowed
>    (limited to this experimental hardware).
> 
> Here's a quick breakdown of the series:
>  - P1-3: General cleanup & other parameter/debugfs-related enhancements.
>  - P4: Introduce a module parameter to override the detected gpuid,
>        which is useful for testing.
>  - P5: Add KUnit infrastructure to the driver for the first time, to
>        validate the error-prone task of parsing a gpuid from a string.
>  - P6: Introduce the titular check.
> 
> Many of the earlier changes could go in on their own, but are not
> critical fixes and would all land in the -next tree anyway so it seems
> pointless to separate them from the context of the later changes.
> 
> Signed-off-by: Matt Coster <matt.coster@...tec.com>
> ---
> Alexandru Dadu (1):
>       drm/imagination: Add gpuid module parameter
> 
> Matt Coster (5):
>       drm/imagination: Simplify module parameters
>       drm/imagination: Validate fw trace group_mask
>       drm/imagination: Load FW trace config at init
>       drm/imagination: KUnit test for pvr_gpuid_decode_string()
>       drm/imagination: Warn or error on unsupported hardware
> 
>  drivers/gpu/drm/imagination/Kconfig        |  12 ++
>  drivers/gpu/drm/imagination/Makefile       |   3 +-
>  drivers/gpu/drm/imagination/pvr_debugfs.c  |   2 -
>  drivers/gpu/drm/imagination/pvr_device.c   | 200 ++++++++++++++++++++++++++---
>  drivers/gpu/drm/imagination/pvr_device.h   |  24 ++--
>  drivers/gpu/drm/imagination/pvr_fw_trace.c | 125 +++++++++++++++---
>  drivers/gpu/drm/imagination/pvr_fw_trace.h |   3 -
>  drivers/gpu/drm/imagination/pvr_params.c   | 147 ---------------------
>  drivers/gpu/drm/imagination/pvr_params.h   |  72 -----------
>  drivers/gpu/drm/imagination/pvr_test.c     |  73 +++++++++++
>  10 files changed, 389 insertions(+), 272 deletions(-)
> ---
> base-commit: 4a768c544f64eaa2fc7cfa91e46f43aa4aad0c40
> change-id: 20260107-device-support-info-f16d81b672d5
> 

For the whole serie,

Reviewed-by: Alessio Belle <alessio.belle@...tec.com>

Thanks,
Alessio