linux-kernel - Re: [PATCH v3 3/4] staging: rtl8723bs: rename CamelCase identifiers to snake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d589ca34-debc-4a4f-811d-fe37802eea7f@gmail.com>
Date: Fri, 16 Jan 2026 20:49:51 +0530
From: Khushal Chitturi <khushalchitturi@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: dan.carpenter@...aro.org, straube.linux@...il.com, hansg@...nel.org,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: rename CamelCase identifiers
 to snake_case

On 1/16/26 6:43 PM, Greg KH wrote:
> On Fri, Jan 16, 2026 at 11:00:51AM +0530, Khushal Chitturi wrote:
>> Rename several CamelCase identifiers across the driver
>> to follow kernel naming conventions.
>>
>> The following identifiers were renamed:
>> 1) UserPriority to user_priority
>> 2) NumTxOkInPeriod to tx_ok_in_period
> 
> Why did you drop the "num"?  That has a meaning, right?  Now this
> variable looks like a boolean, not a count.

Yes, dropping "num" was a mistake.
I'll replace it with num_tx_ok_in_period in v4.

-- 
Regards,
Khushal