linux-kernel - Re: [PATCH] char: mem: fix typo and use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026011646-disengage-enticing-4f86@gregkh>
Date: Fri, 16 Jan 2026 16:28:52 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Minu Jin <s9430939@...er.com>
Cc: arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: mem: fix typo and use pr_err() for logging

On Fri, Jan 02, 2026 at 03:27:59PM +0900, Minu Jin wrote:
> Fix a typo in the comment of read_mem(): funcion -> function
> 
> Replace a raw printk() call in chr_dev_init() with pr_err().
> The original call lacked a log level, which is discouraged.
> 
> Using pr_err() ensures the error is properly categorized and
> follows modern logging practices.

This is two different things, it should be 2 different patches (yes, I'm
being pedantic, sorry, that's because:)

>  	if (register_chrdev(MEM_MAJOR, "mem", &memory_fops))
> -		printk("unable to get major %d for memory devs\n", MEM_MAJOR);
> +		pr_err("unable to get major %d for memory devs\n", MEM_MAJOR);

This change doesn't really do anything different, so it's not needed.
Let's leave it alone as it's been this way for decades.

thanks,

greg k-h