linux-kernel - Re: [PATCH 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWpZUz46SQLGf8WX@redhat.com>
Date: Fri, 16 Jan 2026 10:29:23 -0500
From: Brian Masney <bmasney@...hat.com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: mturquette@...libre.com, sboyd@...nel.org, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/7] clk: st: clkgen-pll: Fix a memory leak in
 clkgen_odf_register()

On Fri, Jan 16, 2026 at 07:38:41PM +0800, Haoxiang Li wrote:
> If clk_register_composite() fails, call kfree() to release
> div and gate.
> 
> Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>

Reviewed-by: Brian Masney <bmasney@...hat.com>

Note for next time: I sent out a Reviewed-by tag on this patch on the
previous version. Please include those tags on the future versions.
The only time it's appropriate to not include the tag is if you make
changes to the patch beyond a trivial change.

Also you may want to consider using b4 for your workflow since it really
simplifies your workflow. There's some documentation available at:

https://b4.docs.kernel.org/en/latest/

Basically, here's a quick workflow of what I do:

    # Start with a clean branch (say today's linux-next)
    # Create a new b4-managed branch
    b4 prep -n my-branch-name
    # Apply your patches
    b4 prep --edit-cover
    b4 prep --auto-to-cc
    b4 prep --check
    b4 send --dry-run
    # Send out your patch series for real
    b4 send

Later if you need to send out a new version, just use the same b4
managed branch. It'll track the patch version number for you (the
PATCH v2 in the subject).

You can use 'b4 trailers'
(https://b4.docs.kernel.org/en/latest/contributor/trailers.html) to pick
up tags from the list.

There's also a b4 web submission endpoint you can use instead of sending
it through a SMTP server:

https://b4.docs.kernel.org/en/latest/contributor/send.html

Brian