linux-kernel - Re: [PATCH 6/7] clk: st: clkgen-pll: Remove redundant kfree() in clkgen_c32_pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aWpdG-wPDbe07yPu@redhat.com>
Date: Fri, 16 Jan 2026 10:45:31 -0500
From: Brian Masney <bmasney@...hat.com>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: mturquette@...libre.com, sboyd@...nel.org, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] clk: st: clkgen-pll: Remove redundant kfree() in
 clkgen_c32_pll_setup()

On Fri, Jan 16, 2026 at 07:38:46PM +0800, Haoxiang Li wrote:
> In clkgen_c32_pll_setup(), pll_name is actually pll_clk -> core->name.
> This variable will be released in clk_unregister() -> __clk_release()
> if some error occurs. Thus kfree(pll_name) will cause a double free.
> Remove this redundant kfree().
> 
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>

A fixes tag is definitely appropriate here.

Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)")
Reviewed-by: Brian Masney <bmasney@...hat.com>