linux-kernel - Re: [PATCH 1/3] clk: Move clk_{save,restore}_context() to COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176853191353.4027.10879981541626027875@lazor>
Date: Thu, 15 Jan 2026 19:51:53 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>, Keerthy <j-keerthy@...com>, Michael Turquette <mturquette@...libre.com>, Russ Dill <Russ.Dill@...com>, Russell King <linux@...linux.org.uk>, Tero Kristo <t-kristo@...com>, Tony Lindgren <tony@...mide.com>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, Geert Uytterhoeven <geert@...ux-m68k.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/3] clk: Move clk_{save,restore}_context() to COMMON_CLK section

Quoting Geert Uytterhoeven (2025-12-01 02:42:26)
> The clk_save_context() and clk_restore_context() helpers are only
> implemented by the Common Clock Framework.  They are not available when
> using legacy clock frameworks.  Dummy implementations are provided, but
> only if no clock support is available at all.
> 
> Hence when CONFIG_HAVE_CLK=y, but CONFIG_COMMON_CLK is not enabled:
> 
>     m68k-linux-gnu-ld: drivers/net/phy/air_en8811h.o: in function `en8811h_resume':
>     air_en8811h.c:(.text+0x83e): undefined reference to `clk_restore_context'
>     m68k-linux-gnu-ld: drivers/net/phy/air_en8811h.o: in function `en8811h_suspend':
>     air_en8811h.c:(.text+0x856): undefined reference to `clk_save_context'
> 
> Fix this by moving forward declarations and dummy implementions from the
> HAVE_CLK to the COMMON_CLK section.
> 
> Fixes: 8b95d1ce3300c411 ("clk: Add functions to save/restore clock context en-masse")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511301553.eaEz1nEW-lkp@intel.com/
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---

Applied to clk-next