linux-kernel - [PATCH 1/4] nvmem: Drop OF node reference on nvmem_add_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260116170846.733558-2-srini@kernel.org>
Date: Fri, 16 Jan 2026 17:08:43 +0000
From: srini@...nel.org
To: gregkh@...uxfoundation.org
Cc: linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
	stable@...r.kernel.org,
	Srinivas Kandagatla <srini@...nel.org>
Subject: [PATCH 1/4] nvmem: Drop OF node reference on nvmem_add_one_cell() failure

From: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

If nvmem_add_one_cell() failed, the ownership of "child" (or "info.np"),
thus its OF reference, is not passed further and function should clean
up by putting the reference it got via earlier of_node_get().  Note that
this is independent of references obtained via for_each_child_of_node()
loop.

Fixes: 50014d659617 ("nvmem: core: use nvmem_add_one_cell() in nvmem_add_cells_from_of()")
Cc: stable@...r.kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Signed-off-by: Srinivas Kandagatla <srini@...nel.org>
---
 drivers/nvmem/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 387c88c55259..ff68fd5ad3d6 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -831,6 +831,7 @@ static int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_nod
 		kfree(info.name);
 		if (ret) {
 			of_node_put(child);
+			of_node_put(info.np);
 			return ret;
 		}
 	}
-- 
2.51.0