linux-kernel - Re: [PATCH] usb: dwc3: google: Remove redundant dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260116173210.5iugbcn3qcjenosx@synopsys.com>
Date: Fri, 16 Jan 2026 17:32:17 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Chen Ni <nichen@...as.ac.cn>
CC: "peter.griffin@...aro.org" <peter.griffin@...aro.org>,
        "andre.draszik@...aro.org" <andre.draszik@...aro.org>,
        "tudor.ambarus@...aro.org" <tudor.ambarus@...aro.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
        "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: google: Remove redundant dev_err()

On Thu, Jan 15, 2026, Chen Ni wrote:
> The platform_get_irq_byname() function already prints an error message
> internally upon failure using dev_err_probe(). Therefore, the explicit
> dev_err() is redundant and results in duplicate error logs.
> 
> Remove the redundant dev_err() call to clean up the error path.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/usb/dwc3/dwc3-google.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
> index a19857bd6b13..2105c72af753 100644
> --- a/drivers/usb/dwc3/dwc3-google.c
> +++ b/drivers/usb/dwc3/dwc3-google.c
> @@ -228,10 +228,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
>  	int irq;
>  
>  	irq = platform_get_irq_byname(pdev, irq_name);
> -	if (irq < 0) {
> -		dev_err(google->dev, "invalid irq name %s\n", irq_name);
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	irq_set_status_flags(irq, IRQ_NOAUTOEN);
>  	ret = devm_request_threaded_irq(google->dev, irq, NULL,
> -- 
> 2.25.1
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>

BR,
Thinh