linux-kernel - Re: [PATCH] mm/highmem: fix __kmap_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260116094815.ca8ef0ad407a4b8612845d8e@linux-foundation.org>
Date: Fri, 16 Jan 2026 09:48:15 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: William Tambe <williamt@...ence.com>
Cc: "linux-mm@...ck.org" <linux-mm@...ck.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "jcmvbkbc@...il.com" <jcmvbkbc@...il.com>
Subject: Re: [PATCH] mm/highmem: fix __kmap_to_page() build error

On Fri, 16 Jan 2026 17:18:21 +0000 William Tambe <williamt@...ence.com> wrote:

> >From 706fa431358390713c47667f6bcaecce56d071cc Mon Sep 17 00:00:00 2001
> From: William Tambe <williamt@...ence.com>
> Date: Thu, 11 Dec 2025 12:38:19 -0800
> Subject: [PATCH] mm/highmem: fix __kmap_to_page() build error
> 
> This changes fixes following build error which is probably a miss from:
> ef6e06b2ef87 highmem: fix kmap_to_page() for kmap_local_page() addresses
> 
> mm/highmem.c:184:66: error: 'pteval' undeclared (first use in this
> function); did you mean 'pte_val'?
> 184 | idx = arch_kmap_local_map_idx(i, pte_pfn(pteval));
> 
> In __kmap_to_page(), pteval is used but does not exist in the function.
> 
> ...
>
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -180,12 +180,13 @@ struct page *__kmap_to_page(void *vaddr)
>  		for (i = 0; i < kctrl->idx; i++) {
>  			unsigned long base_addr;
>  			int idx;
> +			pte_t pteval = kctrl->pteval[i];
>  
>  			idx = arch_kmap_local_map_idx(i, pte_pfn(pteval));
>  			base_addr = __fix_to_virt(FIX_KMAP_BEGIN + idx);
>  
>  			if (base_addr == base)
> -				return pte_page(kctrl->pteval[i]);
> +				return pte_page(pteval);
>  		}
>  	}

lgtm, thanks.  Seems to affect only xtensa?

I wonder why it took three years to find this.