linux-kernel - Re: [PATCH v4 2/4] scripts/kernel-doc: avoid error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ecnpo213.fsf@trenco.lwn.net>
Date: Fri, 16 Jan 2026 11:17:28 -0700
From: Jonathan Corbet <corbet@....net>
To: Randy Dunlap <rdunlap@...radead.org>, Mauro Carvalho Chehab
 <mchehab+huawei@...nel.org>, Linux Doc Mailing List
 <linux-doc@...r.kernel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-kernel@...r.kernel.org, Jani Nikula <jani.nikula@...el.com>, Shuah
 Khan <skhan@...uxfoundation.org>, stable@...r.kernel.org
Subject: Re: [PATCH v4 2/4] scripts/kernel-doc: avoid error_count overflows

Randy Dunlap <rdunlap@...radead.org> writes:

> Mauro,
> The line formatting is weird on one line below
> (looks like 2 text lines are joined).
>
> On 1/14/26 4:57 AM, Mauro Carvalho Chehab wrote:
>> The glibc library limits the return code to 8 bits. We need to
>> stick to this limit when using sys.exit(error_count).
>> 
>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
>> Cc: stable@...r.kernel.org
>> ---
>>  scripts/kernel-doc.py | 25 ++++++++++++++++++-------
>>  1 file changed, 18 insertions(+), 7 deletions(-)
>> 
>> diff --git a/scripts/kernel-doc.py b/scripts/kernel-doc.py
>> index 7a1eaf986bcd..3992ca49d593 100755
>> --- a/scripts/kernel-doc.py
>> +++ b/scripts/kernel-doc.py
>> @@ -116,6 +116,8 @@ SRC_DIR = os.path.dirname(os.path.realpath(__file__))
>>  
>>  sys.path.insert(0, os.path.join(SRC_DIR, LIB_DIR))
>>  
>> +WERROR_RETURN_CODE = 3
>> +
>>  DESC = """
>>  Read C language source or header FILEs, extract embedded documentation comments,
>>  and print formatted documentation to standard output.
>> @@ -176,7 +178,20 @@ class MsgFormatter(logging.Formatter):
>>          return logging.Formatter.format(self, record)
>>  
>>  def main():
>> -    """Main program"""
>> +    """
>> +    Main program
>> +    By default, the return value is:
>> +
>> +    - 0: success or Python version is not compatible with                                                                kernel-doc.  If -Werror is not used, it will also
>
> Here ^^^^^
>
Mauro, can you get me a clean copy?  It seems like we're more than ready
to apply this set otherwise...

Thanks,

jon