[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aWqJ7fg8e1Y2pxVL@lipo.home.arpa>
Date: Fri, 16 Jan 2026 20:56:45 +0200
From: Petre Rodan <petre.rodan@...dimension.ro>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
David Lechner <dlechner@...libre.com>,
Nuno Sá <nuno.sa@...log.com>,
Andy Shevchenko <andy@...nel.org>,
Andreas Klinger <ak@...klinger.de>, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Marcelo Schmitt <marcelo.schmitt1@...il.com>
Subject: Re: [PATCH v3 00/13] iio: pressure: mprls0025pa: driver code cleanup
Hello,
On Wed, Jan 14, 2026 at 07:09:20PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 14, 2026 at 06:55:29PM +0200, Petre Rodan wrote:
> > This series contains a collection of patches to the MPR sensor based
> > on feedback I received for other drivers.
> >
> > major changes:
> > - trigger flag fix (define edge direction only in the device tree)
> > - fix SPI timing violation
> > - fix scan_type struct
> > - fix pressure calculation
> > (does not affect users that define a sensor via the pressure-triplet)
> > - stricter check for the status byte + better error return levels
> > - drop the use of devm_kzalloc()
> > - stick to the datasheet parameters while performing the measurement
> > sequence
> >
> > minor changes:
> > - includes added and removed
> > - rename generic 'buffer' variable to 'rx_buf'
> >
> > Tested on two sensors - MPRLS0015PA0000SA and MPRLS0001BA00001A
>
> This version looks good to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
>
> The change I mentioned can be sent as a followup.
Thank you for the review.
@Jonathan: please ping me when the series is pushed so I create the followup.
best regards,
peter
Download attachment "signature.asc" of type "application/pgp-signature" (871 bytes)
Powered by blists - more mailing lists