linux-kernel - Re: linux-next: Fixes tag needs some work in the qcom tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <olnhf2ritwl4eh4plujlcthohsortsspagdioaqcugvdlgquad@l6pljrt4k4ws>
Date: Fri, 16 Jan 2026 13:42:56 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Brian Masney <bmasney@...hat.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>, 
	Andy Gross <agross@...nel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>, Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: linux-next: Fixes tag needs some work in the qcom tree

On Mon, Jan 12, 2026 at 06:00:19PM -0500, Brian Masney wrote:
> + Bjorn and Konrad,
> 
> On Tue, Jan 13, 2026 at 08:06:06AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   35a48f41b63f ("clk: qcom: regmap-divider: convert from divider_ro_round_rate() to divider_ro_determine_rate()")
> > 
> > Fixes tag
> > 
> >   Fixes: 859a7e020b23 ("clk: qcom: regmap-divider: convert from divider_round_rate() to divider_determine_rate()")
> > 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Also, the subject in the fixes tag is the same as the fixing commit,
> > so I have not idea which commit was intended.
> 
> I missed up my Fixes tag on this commit that was applied to the qcom clk
> tree:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=clk-for-6.20&id=35a48f41b63f67c490f3a2a89b042536be67cf0f
> 
> The Fixes tag should be:
> 
> Fixes: b6f90511c165 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()")
> 
> The SHA is correct. I just have the wrong commit description.
> 

I believe you're saying that both commits should have:

Fixes: b6f90511c165 ("clk: qcom: regmap-divider: convert from round_rate() to determine_rate()")

Can you confirm?

> Bjorn: How would you like to handle this? Do you want me to repost a new
> version of that patch, and you can drop the current version? Or can you
> rebase your branch with the correct Fixes tag?
> 

It's the top two commits of the branch, so if you can confirm my
understanding I'll just fix up HEAD^.

> Sorry about the extra work. Copy and paste error on my part.
> 

No worries, sorry for not catching your mail earlier.

Regards,
Bjorn

> Brian
>