linux-kernel - Re: [PATCH] of: guard pointers to key OF nodes with an #ifdef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqLcRQiV=2g7VdudKheD_12+m_5VcGQX_s5r9_z=7+cBaA@mail.gmail.com>
Date: Thu, 15 Jan 2026 21:21:33 -0600
From: Rob Herring <robh@...nel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Saravana Kannan <saravanak@...nel.org>
Subject: Re: [PATCH] of: guard pointers to key OF nodes with an #ifdef

On Thu, Jan 15, 2026 at 2:21 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
>
> On Thu, 15 Jan 2026 10:18:39 +0100, Bartosz Golaszewski wrote:
> > We declare the pointers to some key OF-nodes unconditionally in
> > linux/of.h but only export them with CONFIG_OF=y. If anyone uses them in
> > code built without devicetree support enabled, the problem will only come
> > to light at link-time. Add an #ifdef guard to catch it at compile-time.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
> > ---
> >  include/linux/of.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
>
> Applied, thanks!

Err, and dropped.

BTW, my ideal fix for this is to eliminate any users of these variables.

Rob