linux-kernel - Re: [PATCH] can: gs_usb: gs_usb_receive_bulk_callback(): unanchor URL on usb_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260116-certain-spicy-ibis-48e797-mkl@pengutronix.de>
Date: Fri, 16 Jan 2026 20:43:51 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Vincent Mailhol <mailhol@...nel.org>
Cc: linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel@...gutronix.de, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] can: gs_usb: gs_usb_receive_bulk_callback(): unanchor
 URL on usb_submit_urb() error

On 16.01.2026 18:00:31, Marc Kleine-Budde wrote:
> In commit 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix
> URB memory leak"), the URB was re-anchored before usb_submit_urb() in
> gs_usb_receive_bulk_callback() to prevent a leak of this URB during
> cleanup.
>
> However, this patch did not take into account that usb_submit_urb() could
> fail. The URB remains anchored and
> usb_kill_anchored_urbs(&parent->rx_submitted) in gs_can_close() loops
> infinitely since the anchor list never becomes empty.
>
> To fix the bug, unanchor the URB when an usb_submit_urb() error occurs,
> also print an info message
>
> Fixes: 7352e1d5932a ("can: gs_usb: gs_usb_receive_bulk_callback(): fix URB memory leak")
> Reported-by: Jakub Kicinski <kuba@...nel.org>
> Closes: https://lore.kernel.org/all/20260110223836.3890248-1-kuba@kernel.org/
> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>

Applied to linux-can.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)