linux-kernel - Re: [PATCH] scripts: generate_rust_analyzer: compile sysroot with correct edition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mrZCD1=1KOuhN=vroW5fQ4372JtzS+p2yUw9rHp_eKnw@mail.gmail.com>
Date: Fri, 16 Jan 2026 20:50:30 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...nel.org>
Cc: Gary Guo <gary@...yguo.net>, Jesung Yang <y.j3ms.n@...il.com>, 
	Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: generate_rust_analyzer: compile sysroot with
 correct edition

On Fri, Jan 16, 2026 at 4:39 PM Tamir Duberstein <tamird@...nel.org> wrote:
>
> This makes sense to me. I can send v2 if there's consensus on this approach.

Sounds good, thanks!

I guess I could also do it on apply since, unless I missed something,
it just requires dropping all the `rust/Makefile` changes, but a v2 is
always good for clarity.

> I didn't notice anything specifically broken, but I did confirm that
> things break generally if RA is configured with the wrong edition.
> This prevents it from indexing sysroot crates (I tested locally with
> edition 2015 and observed broken navigation in macros).
>
> In other words it isn't known to be broken today, but a new Rust
> release could break it tomorrow.

Yeah, agreed.

Cheers,
Miguel