linux-kernel - Re: [PATCH v3] scripts: generate_rust_analyzer: Add message to sysroot assertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kGg9PVWmJtY-LTAuh0-YrvAsBeVCdptB9DxWCvZzcafA@mail.gmail.com>
Date: Fri, 16 Jan 2026 21:08:23 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Maurice Hieronymus <mhi@...lbox.org>, Tamir Duberstein <tamird@...il.com>, Jesung Yang <y.j3ms.n@...il.com>, 
	onur-ozkan <work@...rozkan.dev>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com, 
	gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, 
	a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] scripts: generate_rust_analyzer: Add message to
 sysroot assertion

On Mon, Dec 1, 2025 at 6:01 PM Maurice Hieronymus <mhi@...lbox.org> wrote:
>
> The assertion that checks whether sysroot lies within sysroot_src
> currently fails without explaining why. Add an error message that
> prints both paths to make diagnosing toolchain issues easier.
>
> Signed-off-by: Maurice Hieronymus <mhi@...lbox.org>

It looks like we are removing the assertion, since there are cases
where it does not hold true, like NixOS:

    https://lore.kernel.org/rust-for-linux/20251224135343.32476-1-work@onurozkan.dev/

I will take that one as a fix, which will mean it will land earlier
than things in `rust-next` (where this one would have been), so this
one here will then not be applicable anymore since there will be no
assertion anymore -- I am sorry Maurice, since I know it was one of
your first patches...

I guess it could still be nice to somehow check that the `sysroot_src`
belongs to the same toolchain as the `sysroot` even if it is in a
different path, but I don't know if that is possible in the general
case, and it is likely not worth the complexity even if there is an
elegant way.

Cc'ing Tamir, Jesung and Onur.

Cheers,
Miguel