linux-kernel - Re: [PATCH] spi: xilinx: use device property accessors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E82DCAA8-720D-45F5-ABDD-289A06FE7CE5@nexthop.ai>
Date: Fri, 16 Jan 2026 12:17:18 -0800
From: Abdurrahman Hussain <abdurrahman@...thop.ai>
To: Andrew Lunn <andrew@...n.ch>
Cc: Mark Brown <broonie@...nel.org>,
 Michal Simek <michal.simek@....com>,
 linux-spi@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: xilinx: use device property accessors.



> On Jan 16, 2026, at 12:11 PM, Andrew Lunn <andrew@...n.ch> wrote:
> 
> On Fri, Jan 16, 2026 at 12:00:35PM -0800, Abdurrahman Hussain wrote:
>> 
>> 
>>> On Jan 16, 2026, at 7:23 AM, Andrew Lunn <andrew@...n.ch> wrote:
>>> 
>>> On Thu, Jan 15, 2026 at 12:33:28AM +0000, Abdurrahman Hussain wrote:
>>>> This makes the driver work on non-OF platforms.
>>>> Also, make irq optional, since the driver can already work in
>>>> polling mode.
>>> 
>>> Are you saying ACPI cannot describe interrupts?
>>> 
>>>   Andrew
>> 
> 
>> It can. We have enabled the interrupts through ACPI on Xilinx I2C
>> block and it works great.  For the SPI block we currently have an
>> issue with our FPGA. Luckily the driver works just fine in the
>> polling mode. By just making the interrupts optional makes the same
>> driver usable on a wider range of hardware platforms, with or
>> without the interrupts.
> 
> It would be good to split this change into two patches, one making the
> interrupt optional, and one swapping to device_foo calls. They are
> logically different changes. And the commit message can then explain
> you are doing this so the driver works with hardware with broken
> interrupts.
> 
> Actually, you need three patches, you need to change the DT binding,
> spi-xilinx.yaml, since currently interrupts are required, not
> optional.
> 
>       Andrew

Sounds good! I will split this change into three patches and re-submit.

Thanks for your review, Andrew!

Regards,
Abdurrahman