linux-kernel - Re: [PATCH] scripts: generate_rust_analyzer.py: reduce cfg plumbing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9nz+mbT1Po+mu4LeuZ-+aff9dTjP2aamX-Zpzt1YtTmBA@mail.gmail.com>
Date: Fri, 16 Jan 2026 16:00:59 -0500
From: Tamir Duberstein <tamird@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Jesung Yang <y.j3ms.n@...il.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>, 
	Nicolas Schier <nsc@...nel.org>, Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] scripts: generate_rust_analyzer.py: reduce cfg plumbing

On Fri, Jan 16, 2026 at 2:42 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Fri, Jan 16, 2026 at 5:11 PM Tamir Duberstein <tamird@...nel.org> wrote:
> >
> > Plumb `pin-init{,-internal}` cfgs from Makefile to rust-analyzer and
> > automatically interpret `--cfg <crate>=<cfg>` as applying to <crate>.
>
> So I guess the goal is to simplify things and avoid duplicate
> information, which is good, but in general commits should explain why
> the change is done (i.e. not just what is done), even if it may seem
> obvious (for patches you receive, then you should ask the same to
> submitters! :).
>
> In addition, for the `rust/Makefile` ones, I try to mark those as
> "rust: kbuild:" where possible/reasonable -- for instance, this could
> be split into two patches. The first one would be the "rust: kbuild:"
> factoring out the flags into the new variables and the second would
> then be the rust-analyzer one that only would need the extra two
> arguments in `rust/Makefile`.

Sounds good, will send as two patches in v2.

> The changes themselves seem fine.
>
> Cc'ing Kbuild as well (there is no major change here, but still, I do
> it out of habit).
>
> Thanks!
>
> Cheers,
> Miguel

Thanks!