| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20260116232106.2234978-5-elson.serrao@oss.qualcomm.com>
Date: Fri, 16 Jan 2026 15:21:01 -0800
From: Elson Serrao <elson.serrao@....qualcomm.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Souradeep Chowdhury <quic_schowdhu@...cinc.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 4/9] usb: misc: qcom_eud: add per-path role switch support
The EUD hardware can support multiple High-Speed USB paths, each connected
to different USB controllers. The current implementation uses a single
chip-level role switch, which cannot properly handle multi-path
configurations where each path needs independent role management. Since
EUD is physically present between the USB connector and the controller,
it should also relay the role change requests from the connector.
Restructure the driver to support per-path role switches and remove the
chip-level role switch. Additionally, as EUD need not modify the USB
role upon enabling, remove the unnecessary role switch call from
enable_eud().
Signed-off-by: Elson Serrao <elson.serrao@....qualcomm.com>
---
drivers/usb/misc/qcom_eud.c | 80 ++++++++++++++++++++++++++++++++-----
1 file changed, 70 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c
index 5cebb64f4a67..a58022f50484 100644
--- a/drivers/usb/misc/qcom_eud.c
+++ b/drivers/usb/misc/qcom_eud.c
@@ -38,12 +38,15 @@
struct eud_path {
struct eud_chip *chip;
struct phy *phy;
+ struct usb_role_switch *controller_sw;
+ struct usb_role_switch *eud_sw;
+ enum usb_role curr_role;
+ char name[16];
u8 num;
};
struct eud_chip {
struct device *dev;
- struct usb_role_switch *role_sw;
void __iomem *base;
struct eud_path *paths[EUD_MAX_PORTS];
phys_addr_t mode_mgr;
@@ -129,7 +132,7 @@ static int enable_eud(struct eud_chip *priv)
writel(EUD_INT_VBUS | EUD_INT_SAFE_MODE,
priv->base + EUD_REG_INT1_EN_MASK);
- return usb_role_switch_set_role(priv->role_sw, USB_ROLE_DEVICE);
+ return 0;
}
static int disable_eud(struct eud_chip *priv)
@@ -287,15 +290,21 @@ static irqreturn_t handle_eud_irq(int irq, void *data)
static irqreturn_t handle_eud_irq_thread(int irq, void *data)
{
struct eud_chip *chip = data;
+ struct eud_path *path;
int ret;
+ path = chip->paths[chip->port_idx];
+ if (!path || !path->controller_sw)
+ goto clear_irq;
+
if (chip->usb_attached)
- ret = usb_role_switch_set_role(chip->role_sw, USB_ROLE_DEVICE);
+ ret = usb_role_switch_set_role(path->controller_sw, USB_ROLE_DEVICE);
else
- ret = usb_role_switch_set_role(chip->role_sw, USB_ROLE_HOST);
+ ret = usb_role_switch_set_role(path->controller_sw, USB_ROLE_HOST);
if (ret)
dev_err(chip->dev, "failed to set role switch\n");
+clear_irq:
/* set and clear vbus_int_clr[0] to clear interrupt */
writel(BIT(0), chip->base + EUD_REG_VBUS_INT_CLR);
writel(0, chip->base + EUD_REG_VBUS_INT_CLR);
@@ -303,15 +312,45 @@ static irqreturn_t handle_eud_irq_thread(int irq, void *data)
return IRQ_HANDLED;
}
+static int eud_role_switch_set(struct usb_role_switch *sw, enum usb_role role)
+{
+ struct eud_path *path = usb_role_switch_get_drvdata(sw);
+ int ret;
+
+ /* Forward the role request to the USB controller */
+ ret = usb_role_switch_set_role(path->controller_sw, role);
+ if (ret) {
+ dev_err(path->chip->dev, "Failed to set role %s for port %u: %d\n",
+ usb_role_string(role), path->num, ret);
+ return ret;
+ }
+
+ path->curr_role = role;
+
+ return 0;
+}
+
static void eud_role_switch_release(void *data)
{
struct eud_chip *chip = data;
+ int i;
- usb_role_switch_put(chip->role_sw);
+ for (i = 0; i < EUD_MAX_PORTS; i++) {
+ struct eud_path *path = chip->paths[i];
+
+ if (!path)
+ continue;
+
+ if (path->eud_sw)
+ usb_role_switch_unregister(path->eud_sw);
+ if (path->controller_sw)
+ usb_role_switch_put(path->controller_sw);
+ }
}
static int eud_init_path(struct eud_chip *chip, struct device_node *np)
{
+ struct usb_role_switch_desc role_sw_desc = {};
struct eud_path *path;
u32 path_num;
int ret;
@@ -342,6 +381,32 @@ static int eud_init_path(struct eud_chip *chip, struct device_node *np)
chip->paths[path_num] = path;
+ path->curr_role = USB_ROLE_NONE;
+
+ if (!of_property_read_bool(np, "usb-role-switch"))
+ return 0;
+
+ /* Fetch the USB controller's role switch */
+ path->controller_sw = fwnode_usb_role_switch_get(of_fwnode_handle(np));
+ if (IS_ERR(path->controller_sw))
+ return dev_err_probe(chip->dev, PTR_ERR(path->controller_sw),
+ "Failed to get controller role switch for path %d\n",
+ path_num);
+
+ /* Create a role switch */
+ role_sw_desc.fwnode = of_fwnode_handle(np);
+ role_sw_desc.set = eud_role_switch_set;
+ role_sw_desc.driver_data = path;
+ snprintf(path->name, sizeof(path->name), "eud-path%u", path_num);
+ role_sw_desc.name = path->name;
+
+ path->eud_sw = usb_role_switch_register(chip->dev, &role_sw_desc);
+ if (IS_ERR(path->eud_sw)) {
+ dev_err(chip->dev, "Failed to register EUD role switch for path %d: %ld\n",
+ path_num, PTR_ERR(path->eud_sw));
+ return PTR_ERR(path->eud_sw);
+ }
+
return 0;
}
@@ -359,11 +424,6 @@ static int eud_probe(struct platform_device *pdev)
chip->dev = &pdev->dev;
- chip->role_sw = usb_role_switch_get(&pdev->dev);
- if (IS_ERR(chip->role_sw))
- return dev_err_probe(chip->dev, PTR_ERR(chip->role_sw),
- "failed to get role switch\n");
-
ret = devm_add_action_or_reset(chip->dev, eud_role_switch_release, chip);
if (ret)
return ret;
--
2.34.1
Powered by blists - more mailing lists