linux-kernel - Re: [PATCH v3 2/3] hwmon: (tmp108) Add support for P3T1035 and P3T2030

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202601161234.jWOgBbs8-lkp@intel.com>
Date: Fri, 16 Jan 2026 12:31:37 +0800
From: kernel test robot <lkp@...el.com>
To: Mayank Mahajan <mayankmahajan.x@....com>, linux@...ck-us.net,
	corbet@....net, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-hwmon@...r.kernel.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, priyanka.jain@....com,
	vikash.bansal@....com, Mayank Mahajan <mayankmahajan.x@....com>
Subject: Re: [PATCH v3 2/3] hwmon: (tmp108) Add support for P3T1035 and
 P3T2030

Hi Mayank,

kernel test robot noticed the following build warnings:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on linus/master v6.19-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mayank-Mahajan/hwmon-tmp108-Add-support-for-P3T1035-and-P3T2030/20260115-191549
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20260115111418.1851-2-mayankmahajan.x%40nxp.com
patch subject: [PATCH v3 2/3] hwmon: (tmp108) Add support for P3T1035 and P3T2030
config: xtensa-randconfig-r122-20260116 (https://download.01.org/0day-ci/archive/20260116/202601161234.jWOgBbs8-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260116/202601161234.jWOgBbs8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601161234.jWOgBbs8-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   drivers/hwmon/tmp108.c: note: in included file (through arch/xtensa/include/asm/bitops.h, include/linux/bitops.h, include/linux/log2.h, ...):
   arch/xtensa/include/asm/processor.h:105:2: sparse: sparse: Unsupported xtensa ABI
   arch/xtensa/include/asm/processor.h:135:2: sparse: sparse: Unsupported Xtensa ABI
>> drivers/hwmon/tmp108.c:455:17: sparse: sparse: macro "memcpy" passed 6 arguments, but takes just 3
   drivers/hwmon/tmp108.c:458:17: sparse: sparse: macro "memcpy" passed 6 arguments, but takes just 3
   drivers/hwmon/tmp108.c:618:1: sparse: sparse: bad integer constant expression
   drivers/hwmon/tmp108.c:618:1: sparse: sparse: static assertion failed: "MODULE_INFO(author, ...) contains embedded NUL byte"
   drivers/hwmon/tmp108.c:619:1: sparse: sparse: bad integer constant expression
   drivers/hwmon/tmp108.c:619:1: sparse: sparse: static assertion failed: "MODULE_INFO(description, ...) contains embedded NUL byte"
   drivers/hwmon/tmp108.c:620:1: sparse: sparse: bad integer constant expression
   drivers/hwmon/tmp108.c:620:1: sparse: sparse: static assertion failed: "MODULE_INFO(license, ...) contains embedded NUL byte"

vim +/memcpy +455 drivers/hwmon/tmp108.c

   433	
   434	static int tmp108_common_probe(struct device *dev, struct regmap *regmap, char *name,
   435				       enum tmp108_hw_id hw_id)
   436	{
   437		struct device *hwmon_dev;
   438		struct tmp108 *tmp108;
   439		u32 config;
   440		int err;
   441	
   442		err = devm_regulator_get_enable(dev, "vcc");
   443		if (err)
   444			return dev_err_probe(dev, err, "Failed to enable regulator\n");
   445	
   446		tmp108 = devm_kzalloc(dev, sizeof(*tmp108), GFP_KERNEL);
   447		if (!tmp108)
   448			return -ENOMEM;
   449	
   450		dev_set_drvdata(dev, tmp108);
   451		tmp108->regmap = regmap;
   452		tmp108->hw_id = hw_id;
   453		tmp108->config_reg_16bits = (hw_id == P3T1035_ID) ? false : true;
   454		if (hw_id == P3T1035_ID)
 > 455			memcpy(tmp108->sample_times, (unsigned int[]){ 125, 250, 1000, 4000 },
   456			       sizeof(tmp108->sample_times));
   457		else
   458			memcpy(tmp108->sample_times, (unsigned int[]){ 63, 250, 1000, 4000 },
   459			       sizeof(tmp108->sample_times));
   460	
   461		err = regmap_read(tmp108->regmap, TMP108_REG_CONF, &config);
   462		if (err < 0) {
   463			dev_err(dev, "error reading config register: %d", err);
   464			return err;
   465		}
   466		tmp108->orig_config = config;
   467	
   468		/* Only continuous mode is supported. */
   469		config &= ~TMP108_CONF_MODE_MASK;
   470		config |= TMP108_MODE_CONTINUOUS;
   471		/* Only comparator mode is supported. */
   472		config &= ~TMP108_CONF_TM;
   473	
   474		err = regmap_write(tmp108->regmap, TMP108_REG_CONF, config);
   475		if (err < 0) {
   476			dev_err(dev, "error writing config register: %d", err);
   477			return err;
   478		}
   479	
   480		tmp108->ready_time = jiffies;
   481		if ((tmp108->orig_config & TMP108_CONF_MODE_MASK) ==
   482		    TMP108_MODE_SHUTDOWN)
   483			tmp108->ready_time +=
   484				msecs_to_jiffies(TMP108_CONVERSION_TIME_MS);
   485	
   486		err = devm_add_action_or_reset(dev, tmp108_restore_config, tmp108);
   487		if (err) {
   488			dev_err(dev, "add action or reset failed: %d", err);
   489			return err;
   490		}
   491	
   492		hwmon_dev = devm_hwmon_device_register_with_info(dev, name,
   493								 tmp108,
   494								 &tmp108_chip_info,
   495								 NULL);
   496		return PTR_ERR_OR_ZERO(hwmon_dev);
   497	}
   498	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki