linux-kernel - Re: [PATCH 07/27] clk: bm1880: convert from divider_round_rate() to divider_determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lst5lt4gkjzfj2ozajukmyaozw7xeees63v6omimkvbn7xzgcl@7omzhb45ddlr>
Date: Fri, 16 Jan 2026 10:54:33 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Brian Masney <bmasney@...hat.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 07/27] clk: bm1880: convert from divider_round_rate() to
 divider_determine_rate()

On Thu, Jan 08, 2026 at 04:16:25PM -0500, Brian Masney wrote:
> The divider_round_rate() function is now deprecated, so let's migrate
> to divider_determine_rate() instead so that this deprecated API can be
> removed.
> 
> Note that when the main function itself was migrated to use
> determine_rate, this was mistakenly converted to:
> 
>     req->rate = divider_round_rate(...)
> 
> This is invalid in the case when an error occurs since it can set the
> rate to a negative value.
> 
> Fixes: 64613d7fb42f ("clk: bm1880: convert from round_rate() to determine_rate()")
> Signed-off-by: Brian Masney <bmasney@...hat.com>

Acked-by: Manivannan Sadhasivam <mani@...nel.org>

- Mani

> 
> ---
> To: Manivannan Sadhasivam <mani@...nel.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> ---
>  drivers/clk/clk-bm1880.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/clk-bm1880.c b/drivers/clk/clk-bm1880.c
> index 536df8e828eab83fbd3812135139c703aa7a1ce3..1bdceb36fa87e8250c10a7fc0791379e1533bb38 100644
> --- a/drivers/clk/clk-bm1880.c
> +++ b/drivers/clk/clk-bm1880.c
> @@ -625,10 +625,7 @@ static int bm1880_clk_div_determine_rate(struct clk_hw *hw,
>  						 div->width, div->flags, val);
>  	}
>  
> -	req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
> -				       div->table, div->width, div->flags);
> -
> -	return 0;
> +	return divider_determine_rate(hw, req, div->table, div->width, div->flags);
>  }
>  
>  static int bm1880_clk_div_set_rate(struct clk_hw *hw, unsigned long rate,
> 
> -- 
> 2.52.0
> 

-- 
மணிவண்ணன் சதாசிவம்