linux-kernel - Re: [PATCH 04/27] clk: actions: owl-composite: convert from owl_divider_helper_round_rate() to divider_determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gn56qksoznzuexepv27wfn44xyow3nqzsy7gv7jjvty2orfmga@53xsfbu2guy4>
Date: Fri, 16 Jan 2026 10:57:24 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Brian Masney <bmasney@...hat.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Andreas Färber <afaerber@...e.de>, linux-arm-kernel@...ts.infradead.org, 
	linux-actions@...ts.infradead.org
Subject: Re: [PATCH 04/27] clk: actions: owl-composite: convert from
 owl_divider_helper_round_rate() to divider_determine_rate()

On Thu, Jan 08, 2026 at 04:16:22PM -0500, Brian Masney wrote:
> owl_divider_helper_round_rate() is just a wrapper for
> divider_round_rate(), which is deprecated. Let's migrate to
> divider_determine_rate() instead so that this deprecated API can be
> removed.
> 
> Signed-off-by: Brian Masney <bmasney@...hat.com>

Acked-by: Manivannan Sadhasivam <mani@...nel.org>

- Mani

> 
> ---
> To: "Andreas Färber" <afaerber@...e.de>
> To: Manivannan Sadhasivam <mani@...nel.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-actions@...ts.infradead.org
> ---
>  drivers/clk/actions/owl-composite.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/actions/owl-composite.c b/drivers/clk/actions/owl-composite.c
> index 00b74f8bc4375a8f42e9b54c7bf1affe91e1074a..9540444307d6c960af200ec13e7c60abd47ffc85 100644
> --- a/drivers/clk/actions/owl-composite.c
> +++ b/drivers/clk/actions/owl-composite.c
> @@ -57,15 +57,10 @@ static int owl_comp_div_determine_rate(struct clk_hw *hw,
>  				       struct clk_rate_request *req)
>  {
>  	struct owl_composite *comp = hw_to_owl_comp(hw);
> -	long rate;
> -
> -	rate = owl_divider_helper_round_rate(&comp->common, &comp->rate.div_hw,
> -					     req->rate, &req->best_parent_rate);
> -	if (rate < 0)
> -		return rate;
> +	struct owl_divider_hw *div = &comp->rate.div_hw;
>  
> -	req->rate = rate;
> -	return 0;
> +	return divider_determine_rate(&comp->common.hw, req, div->table,
> +				      div->width, div->div_flags);
>  }
>  
>  static unsigned long owl_comp_div_recalc_rate(struct clk_hw *hw,
> 
> -- 
> 2.52.0
> 

-- 
மணிவண்ணன் சதாசிவம்