linux-kernel - Re: [PATCH v4 00/11] crypto: hisilicon - add fallback function for hisilicon accelerater driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWnVENZPxOM5d5SP@gondor.apana.org.au>
Date: Fri, 16 Jan 2026 14:05:04 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Chenghai Huang <huangchenghai2@...wei.com>
Cc: davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, fanghao11@...wei.com,
	liulongfang@...wei.com, qianweili@...wei.com,
	linwenkai6@...ilicon.com, wangzhou1@...ilicon.com,
	lizhi206@...wei.com, taoqi10@...wei.com
Subject: Re: [PATCH v4 00/11] crypto: hisilicon - add fallback function for
 hisilicon accelerater driver

On Thu, Dec 18, 2025 at 09:44:41PM +0800, Chenghai Huang wrote:
> 1.Supports multiple tfms sharing the same device queue to avoid tfm
> creation failure.
> 2.Support fallback for zip/sec2/hpre when queue allocation fails or
> when processing unsupported specifications.
> 
> When pf_q_num is less than the number of tfms, queues will be
> obtained from devices with fewer references and closer NUMA
> distances(priority: ref counts -> NUMA distances).
> 
> We can test by zswap:
> modprobe hisi_zip uacce_mode=1 pf_q_num=2
> cat /sys/class/uacce/hisi_zip-?/available_instances
> echo hisi-deflate-acomp > /sys/module/zswap/parameters/compressor
> 
> ---
> V3: https://lore.kernel.org/all/20251122074916.2793717-1-huangchenghai2@huawei.com/
> Updates:
> - In patch 7, fix the issue of skipping qp enablement due to incorrect
>   reference count judgment.
> - In patch 6, Supplement the device power wake-up operation before
>   applying for the qp.
> 
> V2: https://lore.kernel.org/all/20250818065714.1916898-1-huangchenghai2@huawei.com/
> Updates:
> - According to crypto framework, support shared queues to address
>   the hardware resource limitation on tfm.
> - Remove the fallback modification for x25519.
> 
> V1: https://lore.kernel.org/all/20250809070829.47204-1-huangchenghai2@huawei.com/
> Updates:
> - Remove unnecessary callback completions.
> - Add CRYPTO_ALG_NEED_FALLBACK to hisi_zip's cra_flags.
> 
> ---
> Chenghai Huang (8):
>   crypto: hisilicon/zip - adjust the way to obtain the req in the
>     callback function
>   crypto: hisilicon/sec - move backlog management to qp and store sqe in
>     qp for callback
>   crypto: hisilicon/qm - enhance the configuration of req_type in queue
>     attributes
>   crypto: hisilicon/qm - centralize the sending locks of each module
>     into qm
>   crypto: hisilicon - consolidate qp creation and start in
>     hisi_qm_alloc_qps_node
>   crypto: hisilicon/qm - add reference counting to queues for tfm kernel
>     reuse
>   crypto: hisilicon/qm - optimize device selection priority based on
>     queue ref count and NUMA distance
>   crypto: hisilicon/zip - support fallback for zip
> 
> Qi Tao (1):
>   crypto: hisilicon/sec2 - support skcipher/aead fallback for hardware
>     queue unavailable
> 
> Weili Qian (1):
>   crypto: hisilicon/hpre - support the hpre algorithm fallback
> 
> lizhi (1):
>   crypto: hisilicon/hpre: extend tag field to 64 bits for better
>     performance
> 
>  drivers/crypto/hisilicon/Kconfig            |   1 +
>  drivers/crypto/hisilicon/hpre/hpre.h        |   5 +-
>  drivers/crypto/hisilicon/hpre/hpre_crypto.c | 416 +++++++++++---------
>  drivers/crypto/hisilicon/hpre/hpre_main.c   |   2 +-
>  drivers/crypto/hisilicon/qm.c               | 206 +++++++---
>  drivers/crypto/hisilicon/sec2/sec.h         |   7 -
>  drivers/crypto/hisilicon/sec2/sec_crypto.c  | 159 ++++----
>  drivers/crypto/hisilicon/sec2/sec_main.c    |  21 +-
>  drivers/crypto/hisilicon/zip/zip.h          |   2 +-
>  drivers/crypto/hisilicon/zip/zip_crypto.c   | 133 ++++---
>  drivers/crypto/hisilicon/zip/zip_main.c     |   4 +-
>  include/linux/hisi_acc_qm.h                 |  14 +-
>  12 files changed, 574 insertions(+), 396 deletions(-)
> 
> -- 
> 2.33.0

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt