linux-kernel - Re: [PATCH v11 10/12] vduse: merge tree search logic of IOTLB_GET_FD and IOTLB_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202601161430.lDfgRE4U-lkp@intel.com>
Date: Fri, 16 Jan 2026 14:40:02 +0800
From: kernel test robot <lkp@...el.com>
To: Eugenio Pérez <eperezma@...hat.com>,
	"Michael S . Tsirkin" <mst@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
	Maxime Coquelin <mcoqueli@...hat.com>,
	Laurent Vivier <lvivier@...hat.com>, Cindy Lu <lulu@...hat.com>,
	jasowang@...hat.com, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Stefano Garzarella <sgarzare@...hat.com>,
	Yongji Xie <xieyongji@...edance.com>,
	Eugenio Pérez <eperezma@...hat.com>
Subject: Re: [PATCH v11 10/12] vduse: merge tree search logic of IOTLB_GET_FD
 and IOTLB_GET_INFO ioctls

Hi Eugenio,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mst-vhost/linux-next]
[also build test WARNING on linus/master v6.19-rc5 next-20260115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eugenio-P-rez/vduse-add-v1-API-definition/20260109-233435
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
patch link:    https://lore.kernel.org/r/20260109152430.512923-11-eperezma%40redhat.com
patch subject: [PATCH v11 10/12] vduse: merge tree search logic of IOTLB_GET_FD and IOTLB_GET_INFO ioctls
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260116/202601161430.lDfgRE4U-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260116/202601161430.lDfgRE4U-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601161430.lDfgRE4U-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/vdpa/vdpa_user/vduse_dev.c:1269:7: warning: variable 'map_file' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    1269 |                 if (f) {
         |                     ^
   drivers/vdpa/vdpa_user/vduse_dev.c:1273:19: note: uninitialized use occurs here
    1273 |                 entry->offset = map_file->offset;
         |                                 ^~~~~~~~
   drivers/vdpa/vdpa_user/vduse_dev.c:1269:3: note: remove the 'if' if its condition is always true
    1269 |                 if (f) {
         |                 ^~~~~~
   drivers/vdpa/vdpa_user/vduse_dev.c:1256:38: note: initialize the variable 'map_file' to silence this warning
    1256 |         const struct vdpa_map_file *map_file;
         |                                             ^
         |                                              = NULL
   1 warning generated.


vim +1269 drivers/vdpa/vdpa_user/vduse_dev.c

  1249	
  1250	static int vduse_dev_iotlb_entry(struct vduse_dev *dev,
  1251					 struct vduse_iotlb_entry *entry,
  1252					 struct file **f, uint64_t *capability)
  1253	{
  1254		int r = -EINVAL;
  1255		struct vhost_iotlb_map *map;
  1256		const struct vdpa_map_file *map_file;
  1257	
  1258		if (entry->start > entry->last)
  1259			return -EINVAL;
  1260	
  1261		mutex_lock(&dev->domain_lock);
  1262		if (!dev->domain)
  1263			goto out;
  1264	
  1265		spin_lock(&dev->domain->iotlb_lock);
  1266		map = vhost_iotlb_itree_first(dev->domain->iotlb, entry->start,
  1267					      entry->last);
  1268		if (map) {
> 1269			if (f) {
  1270				map_file = (struct vdpa_map_file *)map->opaque;
  1271				*f = get_file(map_file->file);
  1272			}
  1273			entry->offset = map_file->offset;
  1274			entry->start = map->start;
  1275			entry->last = map->last;
  1276			entry->perm = map->perm;
  1277			if (capability) {
  1278				*capability = 0;
  1279	
  1280				if (dev->domain->bounce_map && map->start == 0 &&
  1281				    map->last == dev->domain->bounce_size - 1)
  1282					*capability |= VDUSE_IOVA_CAP_UMEM;
  1283			}
  1284	
  1285			r = 0;
  1286		}
  1287		spin_unlock(&dev->domain->iotlb_lock);
  1288	
  1289	out:
  1290		mutex_unlock(&dev->domain_lock);
  1291		return r;
  1292	}
  1293	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki