linux-kernel - Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f1afc5e-d5f4-444e-819c-594f0b1e125b@kernel.org>
Date: Fri, 16 Jan 2026 08:19:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Neeraj Soni <neeraj.soni@....qualcomm.com>
Cc: ulf.hansson@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andersson@...nel.org, konradybcio@...nel.org,
 linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto
 engine for SDHC

On 16/01/2026 06:59, Neeraj Soni wrote:
>> Why this became uppercase?
> Thnaks for pointing out. I will fix this next patch.
>>
>>> +			compatible = "qcom,sc7280-inline-crypto-engine",
>>> +				     "qcom,inline-crypto-engine";
>>> +			reg = <0x0 0x007C8000 0x0 0x18000>;
>>
>> And this? there is no uppercase at all, so maybye you copied it from
>> downstream, but that's not right approach - do not use downstream code.
>>
> Yes it was copied but i missed to align with upstream. Thanks for pointing out. This will be fixed in next patch.

And that's the problem. You must NEVER COPY downstream DTS. We repeat it
and repeat it...

Best regards,
Krzysztof