linux-kernel - Re: [PATCH v2 01/12] gpib: agilent_82350b: Unify *allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026011657-cling-flavoring-2f5b@gregkh>
Date: Fri, 16 Jan 2026 08:34:29 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>
Cc: Dave Penkler <dpenkler@...il.com>,
	Michael Rubin <matchstick@...erthere.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/12] gpib: agilent_82350b: Unify *allocate_private

On Thu, Jan 15, 2026 at 07:20:04PM +0000, Dominik Karol Piątkowski wrote:
> Return values for *allocate_private functions as well as calling code in
> gpib driver are all over the place. Unify them by returning -errno if
> something fails, zero otherwise. Use the returned value as early return
> value in case of error. Replace kmalloc/memset pairs to kzalloc.

This is multiple things in the same patch, which is not a good idea.
Each change should just do one logical thing, this should be broken up
into much smaller pieces.

thanks,

greg k-h