linux-kernel - Re: [PATCH 3/4] s390/vdso: Trim includes in linker script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260116091110-17084414-30a6-4d56-8f88-734d1840ea2b@linutronix.de>
Date: Fri, 16 Jan 2026 09:15:22 +0100
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: Arnd Bergmann <arnd@...db.de>
Cc: "David S . Miller" <davem@...emloft.net>, 
	Andreas Larsson <andreas@...sler.com>, Andy Lutomirski <luto@...nel.org>, 
	Thomas Gleixner <tglx@...nel.org>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, 
	Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, 
	Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, 
	Sven Schnelle <svens@...ux.ibm.com>, sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Linux-Arch <linux-arch@...r.kernel.org>, linux-s390@...r.kernel.org
Subject: Re: [PATCH 3/4] s390/vdso: Trim includes in linker script

On Fri, Jan 16, 2026 at 08:45:02AM +0100, Arnd Bergmann wrote:
> On Fri, Jan 16, 2026, at 08:40, Thomas Weißschuh wrote:
> > Some of the included files are unnecessary or too broad.
> >
> > This is a preparation for a new validation step to validate the
> > consistency of __BITS_PER_LONG. vdso.lds.S may be preprocessed with a
> > 32-bit compiler, but __BITS_PER_LONG is always 64.
> >
> > Trim the includes to the necessary ones.
> >
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> It's certainly a good idea to limit the use of asm/page.h and the
> other headers here. 
> 
> > There are other ways to solve this issue, for example using
> > KBUILD_CPPFLAGS += -m64.
> 
> I think we should probably do that as well, especially since my
> kernel.org cross-compilers still default to a 32-bit s390 target
> for historic reasons, but the kernel no longer supports 32-bit
> userland.

Agreed. However I'd like to keep this series as small as possible.
The same change should also be done to a bunch of other architectures.


Thomas