linux-kernel - Re: [PATCH v5 04/14] ntfs: update inode operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260116083012.GC15119@lst.de>
Date: Fri, 16 Jan 2026 09:30:12 +0100
From: Christoph Hellwig <hch@....de>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@....de, tytso@....edu,
	willy@...radead.org, jack@...e.cz, djwong@...nel.org,
	josef@...icpanda.com, sandeen@...deen.net, rgoldwyn@...e.com,
	xiang@...nel.org, dsterba@...e.com, pali@...nel.org,
	ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com,
	gunho.lee@....com, Hyunchul Lee <hyc.lee@...il.com>
Subject: Re: [PATCH v5 04/14] ntfs: update inode operations

>  int ntfs_test_inode(struct inode *vi, void *data)
>  {
> -	ntfs_attr *na = (ntfs_attr *)data;
> -	ntfs_inode *ni;
> +	struct ntfs_attr *na = (struct ntfs_attr *)data;

No need to cast from void pointers to other pointer types.

> +	struct ntfs_inode *ni;
>  
>  	if (vi->i_ino != na->mft_no)
>  		return 0;
> +
>  	ni = NTFS_I(vi);

Nit: If you're touchiung this anyway, the ni initialization could be
moved to the declaration line.