linux-kernel - Re: [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO from MT8188 dual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260116-soft-rapid-mongrel-8de32e@quoll>
Date: Fri, 16 Jan 2026 09:40:43 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: devicetree@...r.kernel.org, andersson@...nel.org, 
	mathieu.poirier@...aro.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	matthias.bgg@...il.com, tinghan.shen@...iatek.com, olivia.wen@...iatek.com, 
	linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH v2] dt-bindings: remoteproc: mediatek: Remove l1tcm MMIO
 from MT8188 dual

On Thu, Jan 15, 2026 at 12:16:45PM +0100, AngeloGioacchino Del Regno wrote:
>    reg-names:
> -    minItems: 2
> +    minItems: 1
>      maxItems: 3
>  
>    clocks:
> @@ -185,7 +185,7 @@ allOf:
>      then:
>        properties:
>          reg:
> -          maxItems: 3
> +          minItems: 3
>          reg-names:
>            items:
>              - const: sram

I think you also need to update the if:then: section with
mediatek,mt8183-scp+mediatek,mt8186-scp+mediatek,mt8188-scp

> @@ -196,11 +196,22 @@ allOf:
>          compatible:
>            enum:
>              - mediatek,mt8188-scp-dual
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 1
> +        reg-names:
> +          items:
> +            - const: cfg
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
>              - mediatek,mt8195-scp-dual
>      then:
>        properties:
>          reg:
> -          maxItems: 2
> +          minItems: 2

You still need maxItems here, otherwise you change the meaning to 2-3.

>          reg-names:
>            items:
>              - const: cfg
> -- 
> 2.52.0
>