linux-kernel - Re: [PATCH v3 2/5] dt-bindings: i2c: qcom-cci: Document sm6150 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f17af1da-e8fd-4d43-9012-23ac60642faf@kernel.org>
Date: Fri, 16 Jan 2026 09:54:44 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
Cc: Loic Poulain <loic.poulain@....qualcomm.com>,
 Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Robert Foss <rfoss@...nel.org>,
 Todor Tomov <todor.too@...il.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, linux-i2c@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/5] dt-bindings: i2c: qcom-cci: Document sm6150
 compatible

On 16/01/2026 09:34, Wenmeng Liu wrote:
> 
> 
> On 1/16/2026 4:28 PM, Krzysztof Kozlowski wrote:
>> On Thu, Jan 15, 2026 at 06:12:38PM +0800, Wenmeng Liu wrote:
>>> Add the sm6150 CCI device string compatible.
>>>
>>> SM6150 include three clock:
>>> bus: Bus clock responsible for data transfer.
>>> iface: Interface clock responsible for register read and write.
>>> cci: Clock for CCI core operations.
>>>
>>> Signed-off-by: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
>>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
>>> ---
>>>   .../devicetree/bindings/i2c/qcom,i2c-cci.yaml          | 18 ++++++++++++++++++
>>>   1 file changed, 18 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> index a3fe1eea6aece9685674feaa5ec53765c1ce23d8..3472670fdc908ef8f3b3afc68ff437c0435b69a7 100644
>>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>>> @@ -33,6 +33,7 @@ properties:
>>>                 - qcom,sc8280xp-cci
>>>                 - qcom,sdm670-cci
>>>                 - qcom,sdm845-cci
>>> +              - qcom,sm6150-cci
>>>                 - qcom,sm6350-cci
>>>                 - qcom,sm8250-cci
>>>                 - qcom,sm8450-cci
>>> @@ -263,6 +264,23 @@ allOf:
>>>               - const: cpas_ahb
>>>               - const: cci
>>>   
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            enum:
>>> +              - qcom,sm6150-cci
>>> +    then:
>>> +      properties:
>>> +        clocks:
>>> +          minItems: 3
>>> +          maxItems: 3
>>> +        clock-names:
>>> +          items:
>>> +            - const: bus
>>> +            - const: iface
>>> +            - const: cci
>>
>> So basically the same as camnoc_axi+cpas_ahb+cci, so just put it into
>> existing enum with qcom,sm8550-cci.
>>
>> I asked for this at v1.
>> https://lore.kernel.org/all/43efa6fd-53c3-4680-8aca-7b37089ca295@kernel.org/
>>
>>
>> Best regards,
>> Krzysztof
>>
> I raised this question in the previous version.
> And got reply as:

And I asked to integrate them into existing names at v1. So we have v2
which did not do it, v3 now and your patches are still not reviewed :/

Best regards,
Krzysztof