linux-kernel - Re: [PATCH v5 09/14] ntfs: update runlist handling and cluster allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260116092138.GA21396@lst.de>
Date: Fri, 16 Jan 2026 10:21:38 +0100
From: Christoph Hellwig <hch@....de>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@....de, tytso@....edu,
	willy@...radead.org, jack@...e.cz, djwong@...nel.org,
	josef@...icpanda.com, sandeen@...deen.net, rgoldwyn@...e.com,
	xiang@...nel.org, dsterba@...e.com, pali@...nel.org,
	ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com,
	gunho.lee@....com, Hyunchul Lee <hyc.lee@...il.com>
Subject: Re: [PATCH v5 09/14] ntfs: update runlist handling and cluster
 allocator

> +	for (index = start_index; index < end_index; index++) {
> +		folio = filemap_lock_folio(vol->lcnbmp_ino->i_mapping, index);
> +		if (IS_ERR(folio)) {
> +			page_cache_sync_readahead(vol->lcnbmp_ino->i_mapping, ra, NULL,

You probably only want to kick off a read for -ENOENT here, and not
any error?

> +					index, end_index - index);
> +			folio = read_mapping_folio(vol->lcnbmp_ino->i_mapping, index, NULL);
> +			if (!IS_ERR(folio))
> +				folio_lock(folio);
> +		}

either way, this seems like a nice primitive for doing reasonably
efficient reads from the page cache, and I could think of a few
other places to it.  Maybe factor it into helper, even if you keep
it in the ntfs code for now?