linux-kernel - Re: [PATCH v3 23/30] mm: do not open-code lruvec lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <038534F8-F695-4660-A18A-875214C3FE8B@linux.dev>
Date: Fri, 16 Jan 2026 17:20:14 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Qi Zheng <qi.zheng@...ux.dev>
Cc: hannes@...xchg.org,
 hughd@...gle.com,
 mhocko@...e.com,
 roman.gushchin@...ux.dev,
 shakeel.butt@...ux.dev,
 david@...nel.org,
 lorenzo.stoakes@...cle.com,
 ziy@...dia.com,
 harry.yoo@...cle.com,
 yosry.ahmed@...ux.dev,
 imran.f.khan@...cle.com,
 kamalesh.babulal@...cle.com,
 axelrasmussen@...gle.com,
 yuanchu@...gle.com,
 weixugc@...gle.com,
 chenridong@...weicloud.com,
 mkoutny@...e.com,
 akpm@...ux-foundation.org,
 hamzamahfooz@...ux.microsoft.com,
 apais@...ux.microsoft.com,
 lance.yang@...ux.dev,
 linux-mm@...ck.org,
 linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org,
 Qi Zheng <zhengqi.arch@...edance.com>
Subject: Re: [PATCH v3 23/30] mm: do not open-code lruvec lock



> On Jan 14, 2026, at 19:32, Qi Zheng <qi.zheng@...ux.dev> wrote:
> 
> From: Qi Zheng <zhengqi.arch@...edance.com>
> 
> Now we have lruvec_unlock(), lruvec_unlock_irq() and
> lruvec_unlock_irqrestore(), but not the paired lruvec_lock(),
> lruvec_lock_irq() and lruvec_lock_irqsave().
> 
> There is currently no use case for lruvec_lock_irqsave(), so only
> introduce lruvec_lock() and lruvec_lock_irq(), and change all open-code
> places to use these helper function. This looks cleaner and prepares for
> reparenting LRU pages, preventing user from missing RCU lock calls due to
> open-code lruvec lock.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Acked-by: Muchun Song <muchun.song@...ux.dev>