linux-kernel - Re: [tip: perf/core] x86/uprobes: Fix XOL allocation failure for 32-bit tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260116104127.GA1890602@noisy.programming.kicks-ass.net>
Date: Fri, 16 Jan 2026 11:41:27 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: tip-bot2 for Oleg Nesterov <tip-bot2@...utronix.de>,
	linux-tip-commits@...r.kernel.org,
	Paulo Andrade <pandrade@...hat.com>, stable@...r.kernel.org,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [tip: perf/core] x86/uprobes: Fix XOL allocation failure for
 32-bit tasks

On Fri, Jan 16, 2026 at 11:00:23AM +0100, Oleg Nesterov wrote:
> On 01/15, tip-bot2 for Oleg Nesterov wrote:
> >
> > The following commit has been merged into the perf/core branch of tip:
> 
> Damn!
> 
> thanks Peter, but...
> 
> > --- a/arch/x86/kernel/uprobes.c
> > +++ b/arch/x86/kernel/uprobes.c
> > @@ -1823,3 +1823,27 @@ bool is_uprobe_at_func_entry(struct pt_regs *regs)
> >
> >  	return false;
> >  }
> > +
> > +#ifdef CONFIG_IA32_EMULATION
> > +unsigned long __weak arch_uprobe_get_xol_area(void)
> 
> Oh, but x86 version should not be __weak. Copy-and-paste error, sorry :/
> 
> What do you want me to do now,
> 
> 	- send V2 ?
> 
> 	- send another s/__weak// patch on top of this hack?
> 
> 	- or perhaps you can fix this yourself?

I'll have to rebase anyway, might as well fix it directly.

Thanks!