linux-kernel - Re: [PATCH v2 08/10] mm/vma: Use unmap_desc in exit_mmap() and vms_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260116192550.b4c4f18eed80b11ce39a1351@linux-foundation.org>
Date: Fri, 16 Jan 2026 19:25:50 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: SeongJae Park <sj@...nel.org>
Cc: "Liam R. Howlett" <Liam.Howlett@...cle.com>, Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>, kernel test robot <lkp@...el.com>,
 oe-kbuild-all@...ts.linux.dev, Linux Memory Management List
 <linux-mm@...ck.org>, linux-kernel@...r.kernel.org, Suren Baghdasaryan
 <surenb@...gle.com>, Pedro Falcato <pfalcato@...e.de>, David Hildenbrand
 <david@...hat.com>, Vlastimil Babka <vbabka@...e.cz>, Michal Hocko
 <mhocko@...e.com>, Jann Horn <jannh@...gle.com>, shikemeng@...weicloud.com,
 kasong@...cent.com, nphamcs@...il.com, bhe@...hat.com, baohua@...nel.org,
 chrisl@...nel.org, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v2 08/10] mm/vma: Use unmap_desc in exit_mmap() and
 vms_clear_ptes()

On Fri, 16 Jan 2026 17:07:06 -0800 SeongJae Park <sj@...nel.org> wrote:

> > > Suspect you need to add:
> > > 
> > > #include <linux/pgtable.h>
> > > 
> > > to mm/vma_internal.h.
> > > 
> > > Some arches don't define it and that header has:
> > > 
> > > #ifndef USER_PGTABLES_CEILING
> > > #define USER_PGTABLES_CEILING	0UL
> > > #endif
> > > 
> > > ...
> > > 
> > > #ifndef FIRST_USER_ADDRESS
> > > #define FIRST_USER_ADDRESS	0UL
> > > #endif
> 
> But the macro definitions are enclosed by '#ifdef CONFIG_MMU'.  I have
> !CONFIG_MMU build test, which shows similar errors, even after Lorenzo's
> suggestion is applied.  Should we move the definitions out of the '#ifdef
> CONFIG_MMU', or implement another unmap_all_init() for !CONFIG_MMU case?
> 
> I confirmed a simple version of the first option (moving definitions out of
> CONFIG_MMU, in addition to including pgtable.h) like below works at least for
> my !CONFIG_MMU test.
> 

Worked for me, thanks.  I also unbreaks arm allnoconfig.  I usually run
that but I must have missed this time.

I understand that v3 is in the works.  Meanwhile I'll include your patch to
make mm-new a happier place.