linux-kernel - Re: [PATCH v5 0/3] mm: Implement ECC handling for pfn with no struct page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA1PR12MB71997E2E101E55CDE65EA6B3B08AA@SA1PR12MB7199.namprd12.prod.outlook.com>
Date: Sat, 17 Jan 2026 05:36:06 +0000
From: Ankit Agrawal <ankita@...dia.com>
To: Jiaqi Yan <jiaqiyan@...gle.com>
CC: Aniket Agashe <aniketa@...dia.com>, Vikram Sethi <vsethi@...dia.com>,
	Jason Gunthorpe <jgg@...dia.com>, Matt Ochs <mochs@...dia.com>, Shameer
 Kolothum <skolothumtho@...dia.com>, "linmiaohe@...wei.com"
	<linmiaohe@...wei.com>, "nao.horiguchi@...il.com" <nao.horiguchi@...il.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "david@...hat.com"
	<david@...hat.com>, "lorenzo.stoakes@...cle.com"
	<lorenzo.stoakes@...cle.com>, "Liam.Howlett@...cle.com"
	<Liam.Howlett@...cle.com>, "vbabka@...e.cz" <vbabka@...e.cz>,
	"rppt@...nel.org" <rppt@...nel.org>, "surenb@...gle.com" <surenb@...gle.com>,
	"mhocko@...e.com" <mhocko@...e.com>, "tony.luck@...el.com"
	<tony.luck@...el.com>, "bp@...en8.de" <bp@...en8.de>, "rafael@...nel.org"
	<rafael@...nel.org>, "guohanjun@...wei.com" <guohanjun@...wei.com>,
	"mchehab@...nel.org" <mchehab@...nel.org>, "lenb@...nel.org"
	<lenb@...nel.org>, "kevin.tian@...el.com" <kevin.tian@...el.com>,
	"alex@...zbot.org" <alex@...zbot.org>, Neo Jia <cjia@...dia.com>, Kirti
 Wankhede <kwankhede@...dia.com>, "Tarun Gupta (SW-GPU)"
	<targupta@...dia.com>, Zhi Wang <zhiw@...dia.com>, Dheeraj Nigam
	<dnigam@...dia.com>, Krishnakant Jaju <kjaju@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "Jonathan.Cameron@...wei.com"
	<Jonathan.Cameron@...wei.com>, "ira.weiny@...el.com" <ira.weiny@...el.com>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>, "u.kleine-koenig@...libre.com"
	<u.kleine-koenig@...libre.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	Axel Rasmussen <axelrasmussen@...gle.com>
Subject: Re: [PATCH v5 0/3] mm: Implement ECC handling for pfn with no struct
 page

>>
>> v2 -> v3
>> - Rebased to v6.17-rc7.
>> - Skipped the unmapping of PFNMAP during reception of poison. Suggested by
>> Jason Gunthorpe, Jiaqi Yan, Vikram Sethi (Thanks!)
>> - Updated the check to prevent multiple registration to the same PFN
>> range using interval_tree_iter_first. Thanks Shameer Kolothum for the
>> suggestion.
>> - Removed the callback function in the nvgrace-gpu requiring tracking of
>> poisoned PFN as it isn't required anymore.
>
> Hi Ankit,
>
>
> I get that for nvgrace-gpu driver, you removed pfn_address_space_ops
> because there is no need to unmap poisoned HBM page.
>
> What about the nvgrace-egm driver? Now that you removed the
> pfn_address_space_ops callback from pfn_address_space in [1], how can
> nvgrace-egm driver know the poisoned EGM pages at runtime?
>
> I expect the functionality to return retired pages should also include
> runtime poisoned pages, which are not in the list queried from
> egm-retired-pages-data-base during initialization. Or maybe my
> expection is wrong/obsolete?

Hi Jiaqi, yes the EGM code will include consideration for runtime
poisoned pages as well. It will now instead make use of the
pfn_to_vma_pgoff callback merged through https://github.com/torvalds/linux/commit/e6dbcb7c0e7b508d443a9aa6f77f63a2f83b1ae4

> [1] https://lore.kernel.org/linux-mm/20230920140210.12663-2-ankita@nvidia.com
> [2] https://lore.kernel.org/kvm/20250904040828.319452-12-ankita@nvidia.com