linux-kernel - Re: [PATCH net-next] net: ethernet: litex: use devm_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aWrX3KKsOke4Z-3c@inochi.infowork>
Date: Sat, 17 Jan 2026 08:30:18 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: Andrew Lunn <andrew@...n.ch>, Inochi Amaoto <inochiama@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Karol Gugala <kgugala@...micro.com>, Mateusz Holenko <mholenko@...micro.com>, 
	Gabriel Somlo <gsomlo@...il.com>, Joel Stanley <joel@....id.au>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Yixun Lan <dlan@...too.org>, Longbin Li <looong.bin@...il.com>
Subject: Re: [PATCH net-next] net: ethernet: litex: use
 devm_register_netdev() to register netdev

On Fri, Jan 16, 2026 at 06:20:05PM +0100, Andrew Lunn wrote:
> On Fri, Jan 16, 2026 at 08:31:50AM +0800, Inochi Amaoto wrote:
> > Use devm_register_netdev to avoid unnecessary remove() callback in
> > platform_driver structure.
> 
> > -	netdev = devm_alloc_etherdev(&pdev->dev, sizeof(*priv));
> > +	netdev = devm_alloc_etherdev(dev, sizeof(*priv));
> >  	if (!netdev)
> >  		return -ENOMEM;
> 
> The commit message does not fit the actual change.
> 
> You probably want to split this into multiple patches. Ideally you
> want lots of small patches with good commit messages which are
> obviously correct.
> 

In fact, I just change them by the way and it is not a obvious change,
OK, I will split it and send a new version.

Regards,
Inochi