linux-kernel - AW: [PATCH v7] iio: imu: smi330: Convert to common field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DB9PR10MB502041D68C1301A227B40CD7CD8AA@DB9PR10MB5020.EURPRD10.PROD.OUTLOOK.COM>
Date: Sat, 17 Jan 2026 09:56:43 +0000
From: "Shen Jianping (ME-SE/EAD2)" <Jianping.Shen@...bosch.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Jonathan Cameron
	<jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>, Andy Shevchenko
	<andy@...nel.org>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: AW: [PATCH v7] iio: imu: smi330: Convert to common field_{get,prep}()
 helpers


>Betreff: [PATCH v7] iio: imu: smi330: Convert to common field_{get,prep}() helpers
>
>Drop the driver-specific smi330_field_get() and smi330_field_prep() macros, in
>favor of the globally available variants from <linux/bitfield.h>.
>
>Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
>---
>v7:
>  - Update for the renamed smi330_field_{get,prep}() helpers,
>
>v6:
>  - No changes,
>
>v5:
>  - New.
>---
> drivers/iio/imu/smi330/smi330_core.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/iio/imu/smi330/smi330_core.c
>b/drivers/iio/imu/smi330/smi330_core.c
>index 7564f12543e0ca04..83e0dff5d973d046 100644
>--- a/drivers/iio/imu/smi330/smi330_core.c
>+++ b/drivers/iio/imu/smi330/smi330_core.c
>@@ -67,10 +67,6 @@
> #define SMI330_CHIP_ID 0x42
> #define SMI330_SOFT_RESET_DELAY 2000
>
>-/* Non-constant mask variant of FIELD_GET() and FIELD_PREP() */ -#define
>smi330_field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1)) -#define
>smi330_field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
>-
> #define SMI330_ACCEL_CHANNEL(_axis) {					\
> 	.type = IIO_ACCEL,						\
> 	.modified = 1,							\
>@@ -361,7 +357,7 @@ static int smi330_get_sensor_config(struct smi330_data
>*data,
> 	if (ret)
> 		return ret;
>
>-	reg_val = smi330_field_get(attr->mask, reg_val);
>+	reg_val = field_get(attr->mask, reg_val);
>
> 	if (attr->type == IIO_VAL_INT) {
> 		for (i = 0; i < attr->len; i++) {
>@@ -410,7 +406,7 @@ static int smi330_set_sensor_config(struct smi330_data
>*data,
> 	if (ret)
> 		return ret;
>
>-	reg_val = smi330_field_prep(attr->mask, reg_val);
>+	reg_val = field_prep(attr->mask, reg_val);
> 	ret = regmap_update_bits(data->regmap, reg, attr->mask, reg_val);
> 	if (ret)
> 		return ret;
>--
>2.43.0

Hi Geert

Thanks for using the standard kernel implementation.
Reviewed-by: Jianping Shen <Jianping.Shen@...bosch.com>